[SERVER-44899] Remove --start-group and --end-group from link command lines in SCons Created: 02/Dec/19  Updated: 29/Oct/23  Resolved: 03/Dec/19

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.3.3

Type: Improvement Priority: Major - P3
Reporter: Andy Schwerin Assignee: Andrew Morrow (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Dev Platform 2019-12-16
Participants:

 Description   

Now that the link graph is acyclic, it should be safe and even desirable to remove the -Wl,--start-group and --Wl,--end-group arguments in the Linux and BSD builds. It should actually be OK to remove the entire LINK_LIBGROUP_START and LINK_LIBGROUP_END concepts from libdeps as well. It's a minor code simplification, and may modestly speed up static link times on systems with older linkers.

Unfortunately, the "whole archive" requirement remains.



 Comments   
Comment by Githook User [ 03/Dec/19 ]

Author:

{'name': 'Andrew Morrow', 'email': 'andrew.morrow@10gen.com'}

Message: SERVER-44899 The acyclic library dependency graph no longer requires link group arguments
Branch: master
https://github.com/mongodb/mongo/commit/474b930341f98ed8ab68bd82be69e94516689a44

Comment by Andrew Morrow (Inactive) [ 02/Dec/19 ]

schwerin - I did attempt this at one point and wasn't able to measure a speedup, but I agree it can't hurt to remove it now.

Generated at Thu Feb 08 05:07:18 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.