[SERVER-45002] Addition of "comment" field to getMore breaks agg commands with comment during upgrade of sharded cluster Created: 06/Dec/19 Updated: 29/Oct/23 Resolved: 27/Jan/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Aggregation Framework, Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.4 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | David Storch | Assignee: | David Storch |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | qexec-team | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | |||||||||||||||||||||||||||||||||||||||||||||||||
| Operating System: | ALL | |||||||||||||||||||||||||||||||||||||||||||||||||
| Steps To Reproduce: | The following script reproduces the issue:
|
|||||||||||||||||||||||||||||||||||||||||||||||||
| Sprint: | Query 2019-12-30, Query 2020-01-13, Query 2020-01-27, Query 2020-02-10 | |||||||||||||||||||||||||||||||||||||||||||||||||
| Participants: | ||||||||||||||||||||||||||||||||||||||||||||||||||
| Linked BF Score: | 49 | |||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
In Suppose an agg command is sent to a cluster with both 4.4 and 4.2 shards during the 4.2 <=> 4.4 upgrade/downgrade. If a 4.4 node needs to send a getMore to a 4.2 node during execution of the query, it will append the comment. However, the changes for In order to fix this, we need to make sure that a 4.4 mongod does not append the comment to any getMore commands until the upgrade to 4.4 is complete and the featureCompatibilityVersion is fully upgraded to "4.4". Since the shards must be upgraded before mongos, no changes are necessary to the logic that dispatches getMores from mongos to the shards. |
| Comments |
| Comment by Githook User [ 27/Jan/20 ] |
|
Author: {'username': 'dstorch', 'name': 'David Storch', 'email': 'david.storch@10gen.com'}Message: create mode 100644 jstests/multiVersion/agg_with_comment_during_upgrade.js |
| Comment by Kaloian Manassiev [ 26/Jan/20 ] |
|
I believe the dependent |
| Comment by David Storch [ 24/Jan/20 ] |
|
This is currently blocked. An early version of this patch had a C++ global initialization-order fiasco bug, so I need to get a green build on the ASAN builder before merging. However, db_s_collection_sharding_runtime_test appears to be still broken in master: see https://evergreen.mongodb.com/task/mongodb_mongo_master_ubuntu1804_debug_aubsan_lite_unittests_patch_3c77b4ab9e633b3e36688ef1866c29380d9267eb_5e2b534357e85a6fffa2edd1_20_01_24_20_29_37##%257B%2522compare%2522%253A%255B%257B%2522hash%2522%253A%25223c77b4ab9e633b3e36688ef1866c29380d9267eb%2522%257D%255D%257D. I'll need to re-run a patch build once the ASAN builder gets fixed. |