[SERVER-45024] Refactor the CollectionRangeDeleter to remove dependency on MetadataManager Created: 09/Dec/19 Updated: 29/Oct/23 Resolved: 15/Jan/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.3 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Matthew Saltz (Inactive) | Assignee: | Matthew Saltz (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Sprint: | Sharding 2019-12-16, Sharding 2019-12-30, Sharding 2020-01-13, Sharding 2020-01-27 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Linked BF Score: | 32 | ||||||||||||||||
| Description |
|
The CollectionRangeDeleter is currently extremely complex to reason about. Its main function is a static function that then calls back into a friend class (the MetadataManager) to access an instance of CollectionRangeDeleter, and it has to acquire and release locks to ensure the continued validity of the MetadataManager state as it processes a range. In addition, the logic for scheduling tasks is very complex and spread across a lot of code. It's all very brittle and making changes is extremely difficult. We should refactor it so that: |
| Comments |
| Comment by Githook User [ 15/Jan/20 ] |
|
Author: {'name': 'Matthew Saltz', 'email': 'matthew.saltz@mongodb.com', 'username': 'saltzm'}Message: |
| Comment by Githook User [ 13/Jan/20 ] |
|
Author: {'name': 'Matthew Saltz', 'email': 'matthew.saltz@mongodb.com', 'username': 'saltzm'}Message: |
| Comment by Githook User [ 10/Jan/20 ] |
|
Author: {'name': 'Matthew Saltz', 'email': 'matthew.saltz@mongodb.com', 'username': 'saltzm'}Message: |
| Comment by Githook User [ 31/Dec/19 ] |
|
Author: {'name': 'Matthew Saltz', 'email': 'matthew.saltz@mongodb.com', 'username': 'saltzm'}Message: |
| Comment by Githook User [ 18/Dec/19 ] |
|
Author: {'name': 'Matthew Saltz', 'email': 'matthew.saltz@mongodb.com', 'username': 'saltzm'}Message: |