[SERVER-45028] move timestamping logic for completing single-phased index builds within IndexBuildsCoordinator Created: 09/Dec/19 Updated: 29/Oct/23 Resolved: 13/Dec/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.3 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Benety Goh | Assignee: | Benety Goh |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||||||
| Sprint: | Execution Team 2019-12-16 | ||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Linked BF Score: | 78 | ||||||||||||||||||||||||
| Description |
|
Single phased index build currently obtain a ghost timestamp for completing the index build on secondaries in the IndexBuildsCoordinator::onCommitIndexBuild() callback. Unfortunately, this only occurs under feature compatibility version 4.4. We should consider moving this logic to the onCreateIndex() callback where it will not be be affected by the current FCV. |
| Comments |
| Comment by Suganthi Mani [ 27/Dec/19 ] |
|
benety.goh, since onCreateEachFn & onCommitFn now sets the ghost timestamp for catlog writes on secondaries (w/ FCV set to 4.2 & 4.4), then what's the purpose of calling IndexTimestampHelper::setGhostCommitTimestampForCatalogWrite here. Also, that line doesn't do anything because requiresGhostCommitTimestampForWrite() will return false asĀ writesAreReplicated() returns false at that point. Is there any plan to remove that line to make it easy for future readers? |
| Comment by Benety Goh [ 16/Dec/19 ] |
|
This issue was introduced in |
| Comment by Githook User [ 13/Dec/19 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: |
| Comment by Benety Goh [ 11/Dec/19 ] |
|
There is some cleanup to be done for the single-phased index build completion timestamp in IndexBuildsCoordinator but this is better handled as part of |