[SERVER-45033] Log operations we do, not those we were told to do, in atomic applyOps oplog entries Created: 09/Dec/19  Updated: 29/Oct/23  Resolved: 20/Apr/22

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 6.1.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Judah Schvimer Assignee: Josef Ahmad
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-64972 Generate change stream events for bat... Closed
Issue split
split from SERVER-44450 Do not add fromMigrate field to apply... Closed
Related
related to SERVER-66350 Remove OpObserver::onApplyOps function Closed
related to SERVER-46221 Remove oplogApplicationEnforcesSteady... Open
is related to SERVER-42845 Change streams should return events f... Closed
is related to SERVER-21700 Do not relax constraints during stead... Closed
is related to SERVER-33182 Remove atomic applyOps Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2022-04-18, Execution Team 2022-05-02
Participants:

 Description   

This is split from SERVER-44450 to make atomic upserts log as inserts and atomic noop deletes not get logged.



 Comments   
Comment by Suganthi Mani [ 12/Jul/22 ]

Thanks judah.schvimer@mongodb.com for pointing it out!

Comment by Judah Schvimer [ 12/Jul/22 ]

suganthi.mani@mongodb.com, yes we should! This is tracked in SERVER-66350.

Comment by Suganthi Mani [ 12/Jul/22 ]

josef.ahmad@mongodb.com It seems after this commit, onapplyOps() is no longer used anywhere in the code base. So, I think we should remove it??? or am I missing something?

Comment by Githook User [ 19/Apr/22 ]

Author:

{'name': 'Josef Ahmad', 'email': 'josef.ahmad@mongodb.com', 'username': 'josefahmad'}

Message: SERVER-45033 Atomic applyOps logs the actual writes not the request
Branch: master
https://github.com/mongodb/mongo/commit/12bbc9f4f1a5d7a4826f2f2847c0e03ebc93103e

Comment by Githook User [ 19/Apr/22 ]

Author:

{'name': 'Josef Ahmad', 'email': 'josef.ahmad@mongodb.com', 'username': 'josefahmad'}

Message: SERVER-45033 applyOps logs against the admin db
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/bc1fc025680cebc9d31b43a4f429c8c924459d75

Comment by Josef Ahmad [ 08/Apr/22 ]

SERVER-63047 makes a WriteUnitOfWork replicate multiple writes replicate atomically and may come in handy to resolve this ticket. At commit, the WUOW will just emit an applyOps entry that reflects the writes occurred. We might even be able to remove the acquisition of the strong exclusive global lock.

Comment by Judah Schvimer [ 09/Dec/19 ]

SERVER-33182 to remove atomic applyOps could be done instead.

Generated at Thu Feb 08 05:07:41 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.