[SERVER-45087] Check Oplog Commitment condition on reconfig Created: 12/Dec/19  Updated: 29/Oct/23  Resolved: 26/Feb/20

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.3.4

Type: Task Priority: Major - P3
Reporter: Siyuan Zhou Assignee: William Schultz (Inactive)
Resolution: Fixed Votes: 0
Labels: safe-reconfig-cmd
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
Related
related to SERVER-45086 Record the last committed optime in t... Closed
related to SERVER-46894 Wait for the current config to be com... Closed
is related to SERVER-46473 Config replication and oplog commitme... Closed
is related to SERVER-46522 Config oplog commitment wait must ret... Closed
Backwards Compatibility: Fully Compatible
Sprint: Repl 2020-02-10, Repl 2020-02-24, Repl 2020-03-09
Participants:
Linked BF Score: 28

 Description   

Oplog Commitment condition checks all committed entries in the previous config C_i-1 are also committed in the current config C_i.

Skip oplog commitment check on force reconfig.



 Comments   
Comment by Siyuan Zhou [ 17/Apr/20 ]

The waiting behavior of this ticket has been superseded by SERVER-46894. The checking before reconfig in the ticket is still valid.

Comment by Githook User [ 28/Feb/20 ]

Author:

{'name': 'William Schultz', 'username': 'will62794', 'email': 'william.schultz@mongodb.com'}

Message: SERVER-45087 Simplify config commitment log message format
Branch: master
https://github.com/mongodb/mongo/commit/e322f063d586b29ddefa655c82f0367a10959b98

Comment by Githook User [ 27/Feb/20 ]

Author:

{'username': 'will62794', 'name': 'William Schultz', 'email': 'william.schultz@mongodb.com'}

Message: SERVER-45087 Log message when new replica set config becomes committed
Branch: master
https://github.com/mongodb/mongo/commit/d1d4d04ef73a89301740b9cbd2e31f1e3b400141

Comment by Githook User [ 27/Feb/20 ]

Author:

{'name': 'William Schultz', 'username': 'will62794', 'email': 'william.schultz@mongodb.com'}

Message: SERVER-45087 Move oplog commitment precondition check inside reconfig critical section
Branch: master
https://github.com/mongodb/mongo/commit/98086ef84372c32400e24b262eabaee85e6db67a

Comment by Githook User [ 27/Feb/20 ]

Author:

{'username': 'will62794', 'name': 'William Schultz', 'email': 'william.schultz@mongodb.com'}

Message: SERVER-45087 JS tests that check oplog commitment condition must wait for config replication
Branch: master
https://github.com/mongodb/mongo/commit/1d1934e6fd3b56b6b4bfd0f47b2a56d7bd5b05cd

Comment by Githook User [ 26/Feb/20 ]

Author:

{'username': 'will62794', 'name': 'William Schultz', 'email': 'william.schultz@mongodb.com'}

Message: SERVER-45087 Check oplog commitment condition on replica set reconfig

create mode 100644 jstests/replsets/reconfig_waits_for_oplog_commitment_condition.js
create mode 100644 jstests/replsets/reconfig_waits_for_oplog_commitment_condition_when_leaving_force.js
Branch: master
https://github.com/mongodb/mongo/commit/eb08c1db38cff911a07d51e5c1d6765ac9b83dfa

Comment by Siyuan Zhou [ 16/Dec/19 ]

As daniel.hatcher suggested, we need to return the detailed reasons when a safe reconfig fails.

When a safe reconfig succeeds, we should log that it's committed.

Generated at Thu Feb 08 05:07:50 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.