[SERVER-45120] Move localSetTime out of RWConcernDefault and into DistCache::Value Created: 13/Dec/19 Updated: 29/Oct/23 Resolved: 14/Feb/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.4 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Kevin Pulo | Assignee: | Kaloian Manassiev |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Sharding 2020-02-24 |
| Participants: |
| Description |
|
Currently the localSetTime field is part of the persisted state in RWConcernDefault. While it makes sense to persist epoch and setTime, localSetTime will vary across the cluster. It should instead be in DistCache::Value (alongside the _isValid atomic bool) as a const Date_t. This would also allow the code that sets localSetTime in ReadWriteConcernDefaults::Cache::lookup() to instead happen when the DistCache::Value objects are constructed (i.e. make the constructor require the localSetTime date). |
| Comments |
| Comment by Githook User [ 14/Feb/20 ] |
|
Author: {'name': 'Kaloian Manassiev', 'username': 'kaloianm', 'email': 'kaloian.manassiev@mongodb.com'}Message: |