[SERVER-45130] Deferred evaluation of ICECC_VERSION conflicts with the Ninja generator Created: 13/Dec/19  Updated: 29/Oct/23  Resolved: 17/Dec/19

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 4.3.3

Type: Bug Priority: Critical - P2
Reporter: Andrew Morrow (Inactive) Assignee: Andrew Morrow (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Steps To Reproduce:

Pull 3da6513067131a50323f3388b8dc2918da885732 or later and try to produce a Ninja file that uses icecream.

Sprint: Dev Platform 2019-12-16, Dev Platform 2019-12-30
Participants:

 Description   

The icecream.py tool uses some generators to interpolate in the icecream environment variables. However, these generators rely on behavior that the Ninja builder disables, leading to a conflict.

There doesn't seem to be a real need to defer (or re-evaluate) the value of these variables, so using generators seems unwarranted.

We can just evaluate earlier, before the Ninja generator takes over.



 Comments   
Comment by Githook User [ 17/Dec/19 ]

Author:

{'name': 'Andrew Morrow', 'email': 'andrew.morrow@10gen.com'}

Message: SERVER-45130 Make icecc tool resilient to ninja tool
Branch: master
https://github.com/mongodb/mongo/commit/1cace75040174b743990435cdea3400e7c21dce3

Generated at Thu Feb 08 05:07:58 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.