[SERVER-45156] SockAddr constructor should take sockaddr, not sockaddr_storage Created: 14/Dec/19  Updated: 29/Oct/23  Resolved: 18/Dec/19

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.2.5, 4.3.3, 3.6.18, 4.0.18

Type: Bug Priority: Major - P3
Reporter: Mark Benvenuto Assignee: Mark Benvenuto
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
is depended on by SERVER-42278 Log SockAddrs produced during LDAP co... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.2, v4.0, v3.6
Sprint: Security 2019-12-30
Participants:
Linked BF Score: 50

 Description   

The SockAddr constructor:
SockAddr::SockAddr(const sockaddr_storage& other, socklen_t size)
will deep copy sockaddr_storage based on sizeof(sockaddr_storage).

The sockaddr_storage type should only be used for storing data and not be a constructor parameter. The constructor should instead take a (sockaddr*, socklen_t).



 Comments   
Comment by Githook User [ 19/Mar/20 ]

Author:

{'email': 'mark.benvenuto@mongodb.com', 'name': 'Mark Benvenuto', 'username': 'markbenvenuto'}

Message: SERVER-45156 SockAddr constructor should take sockaddr, not sockaddr_storage

(cherry picked from commit e742c986376a7c06cee67d369261feab0efea1d3)
Branch: v3.6
https://github.com/mongodb/mongo/commit/6bf3b36c59640fbcab75ceca0b12ec1480f7094d

Comment by Githook User [ 19/Mar/20 ]

Author:

{'name': 'Mark Benvenuto', 'username': 'markbenvenuto', 'email': 'mark.benvenuto@mongodb.com'}

Message: SERVER-45156 SockAddr constructor should take sockaddr, not sockaddr_storage

(cherry picked from commit b9a99e1e6d53504007f01c90cb1ee7726aa7eff0)
Branch: v3.6
https://github.com/10gen/mongo-enterprise-modules/commit/6b36fafff9484dee56c54ac07734b57e646f46b1

Comment by Githook User [ 19/Mar/20 ]

Author:

{'email': 'mark.benvenuto@mongodb.com', 'name': 'Mark Benvenuto', 'username': 'markbenvenuto'}

Message: SERVER-45156 SockAddr constructor should take sockaddr, not sockaddr_storage

(cherry picked from commit e742c986376a7c06cee67d369261feab0efea1d3)
Branch: v4.0
https://github.com/mongodb/mongo/commit/aacf29014cd91d81dc4ca01648ebe2d2e9ea16dd

Comment by Githook User [ 19/Mar/20 ]

Author:

{'email': 'mark.benvenuto@mongodb.com', 'name': 'Mark Benvenuto', 'username': 'markbenvenuto'}

Message: SERVER-45156 SockAddr constructor should take sockaddr, not sockaddr_storage

(cherry picked from commit b9a99e1e6d53504007f01c90cb1ee7726aa7eff0)
Branch: v4.0
https://github.com/10gen/mongo-enterprise-modules/commit/139329283682d3d3861c19d9af20d76e4254175c

Comment by Githook User [ 13/Mar/20 ]

Author:

{'name': 'Mark Benvenuto', 'username': 'markbenvenuto', 'email': 'mark.benvenuto@mongodb.com'}

Message: SERVER-45156 SockAddr constructor should take sockaddr, not sockaddr_storage

(cherry picked from commit e742c986376a7c06cee67d369261feab0efea1d3)
Branch: v4.2
https://github.com/mongodb/mongo/commit/88053febad75e48bb5ec7120f96edc0c17fb1402

Comment by Githook User [ 13/Mar/20 ]

Author:

{'name': 'Mark Benvenuto', 'username': 'markbenvenuto', 'email': 'mark.benvenuto@mongodb.com'}

Message: SERVER-45156 SockAddr constructor should take sockaddr, not sockaddr_storage

(cherry picked from commit b9a99e1e6d53504007f01c90cb1ee7726aa7eff0)
Branch: v4.2
https://github.com/10gen/mongo-enterprise-modules/commit/fe5714c77b0184f5f84468b0a3a94967c02e09ef

Comment by Githook User [ 18/Dec/19 ]

Author:

{'name': 'Mark Benvenuto', 'email': 'mark.benvenuto@mongodb.com', 'username': 'markbenvenuto'}

Message: SERVER-45156 SockAddr constructor should take sockaddr, not sockaddr_storage
Branch: master
https://github.com/mongodb/mongo/commit/e742c986376a7c06cee67d369261feab0efea1d3

Comment by Githook User [ 18/Dec/19 ]

Author:

{'name': 'Mark Benvenuto', 'email': 'mark.benvenuto@mongodb.com', 'username': 'markbenvenuto'}

Message: SERVER-45156 SockAddr constructor should take sockaddr, not sockaddr_storage
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/b9a99e1e6d53504007f01c90cb1ee7726aa7eff0

Generated at Thu Feb 08 05:08:03 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.