[SERVER-45236] Teach our SCons implementation to reiterate CFLAGS on the link line Created: 18/Dec/19  Updated: 27/Oct/23  Resolved: 27/Oct/23

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive)
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Server Development Platform
Backwards Compatibility: Fully Compatible
Sprint: Dev Platform 2021-02-22, Dev Platform 2021-03-08, Dev Platform 2021-03-22
Participants:

 Description   

There are lots of places where we add flags to both the C[{C,XX}]FLAGS and [SH]LINKFLAGS, because these flags need to be present for both tasks. Generally, we do this on platforms that use clang/gcc, since there we invoke the compiler to drive the link. So flags that affect both compile and link should appear in both. It would be easier if we just always included C[{C,XX}]FLAGS on the link line, and then we wouldn't need to add the flags in two places.



 Comments   
Comment by Githook User [ 17/Feb/21 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: Revert "SERVER-45236 Eliminate need to reiterate compile flags on the link line"

This reverts commit 6674514dfcc5b3ec4e80c2b727c8d7f9f6f6e86f.
Branch: master
https://github.com/mongodb/mongo/commit/13e8d7c56b5105a318643b9e3e93d4a1058dcb8e

Comment by Githook User [ 16/Feb/21 ]

Author:

{'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}

Message: SERVER-45236 Eliminate need to reiterate compile flags on the link line
Branch: master
https://github.com/mongodb/mongo/commit/6674514dfcc5b3ec4e80c2b727c8d7f9f6f6e86f

Generated at Thu Feb 08 05:08:16 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.