[SERVER-45254] Update architecture guide for streamable isMaster Created: 19/Dec/19  Updated: 29/Oct/23  Resolved: 30/Jan/20

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.3.4

Type: Task Priority: Major - P3
Reporter: Tess Avitabile (Inactive) Assignee: Tess Avitabile (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Repl 2020-02-10
Participants:

 Comments   
Comment by Githook User [ 30/Jan/20 ]

Author:

{'name': 'Tess Avitabile', 'username': 'tessavitabile', 'email': 'tess.avitabile@mongodb.com'}

Message: SERVER-45254 Update architecture guide for streamable isMaster
Branch: master
https://github.com/mongodb/mongo/commit/6375ee8006c6f8a025b29036be586e03d34e4fe2

Comment by Tess Avitabile (Inactive) [ 19/Dec/19 ]

Thanks for the input! I'll mark this as required.

Comment by Pavithra Vetriselvan [ 19/Dec/19 ]

I think SDAM might be out of scope for the architecture guide. I imagine if we were to add something about the TopologyVersion, it would be in the "Replication and Topology Coordinators" section.

For example (additions in bold),
"The TopologyCoordinator is in charge of maintaining state about the topology of the cluster. On significant topology changes (state changes, reconfig, etc), the TopologyCoordinator updates its TopologyVersion. The isMaster<link to documentation?> command awaits changes in the TopologyVersion before returning.

It is non-blocking and does a large amount of a node's decision making surrounding replication. Most replication command requests and responses are filled in here."

Note, I left featureCompatibilityVersion changes out of this explanation because it also is not covered in the guide yet.

Comment by Samyukta Lanka [ 19/Dec/19 ]

I think the changes around ToplogyVersion would be helpful to have in the architecture guide and would fit the level of detail that we already have.

Comment by Tess Avitabile (Inactive) [ 19/Dec/19 ]

I'm unsure whether to close this ticket. The architecture guide does not currently cover isMaster or SDAM. However, this project does change the TopologyCoordinator to store a TopologyVersion. The TopologyVersion is updated on significant topology changes, e.g. state change, reconfig, featureCompatibilityVersion change. The TopologyVersion is used by isMaster commands to await a significant topology change before returning. pavithra.vetriselvan, samy.lanka@mongodb.com, does this level of detail belong in the architecture guide?

Generated at Thu Feb 08 05:08:19 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.