[SERVER-45260] shell helpers in shell_utils_launcher.cpp shouldn't use verify() Created: 19/Dec/19  Updated: 29/Oct/23  Resolved: 21/Apr/20

Status: Closed
Project: Core Server
Component/s: Shell
Affects Version/s: None
Fix Version/s: 4.4.1, 4.7.0

Type: Bug Priority: Major - P3
Reporter: Mira Carey Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Problem/Incident
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.4
Sprint: Dev Tools 2020-02-24, Dev Tools 2020-03-09, Service Arch 2020-04-06, Service arch 2020-04-20, Service arch 2020-05-04
Participants:
Linked BF Score: 48

 Description   

Some shell helpers like PathExists use verify in their implementations. There's no real good reason for this, and it causes the debug versions of the shell to crash on incorrect inputs.

A list of locations in shell_utils_launcher.cpp that should probably get fixed up includes:

  • ResetDbpath
  • PathExists
  • CopyDbpath
  • getSignal
  • ProgrammerRunner's ctor


 Comments   
Comment by Githook User [ 18/Aug/20 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-45260 replace verify with uassert in shell_utils_launcher

(cherry picked from commit dfe28134f9b76ecc1d1a938c46b689a71bcf3c33)
Branch: v4.4
https://github.com/mongodb/mongo/commit/a8a43a2d01d25d4f78a4fb13127aaef7778fc285

Comment by Githook User [ 21/Apr/20 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-45260 replace verify with uassert in shell_utils_launcher
Branch: master
https://github.com/mongodb/mongo/commit/dfe28134f9b76ecc1d1a938c46b689a71bcf3c33

Comment by Billy Donahue [ 17/Apr/20 ]

CR: https://mongodbcr.appspot.com/577040025/

Generated at Thu Feb 08 05:08:20 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.