[SERVER-45269] break up LogV2Test/Types Created: 20/Dec/19  Updated: 29/Oct/23  Resolved: 25/Mar/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: 4.3 Required
Fix Version/s: 4.4.0-rc4, 4.7.0

Type: Improvement Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.4
Sprint: Service Arch 2020-04-06
Participants:

 Description   

It's a 200 line function, testing everything under one test.

The tests are not independent, and there's pressure to write quick one-and-done tests to avoid adding complexity to the function. If there's a problem with one type, we can't isolate it with a test --filter.

Anyway, this ticket captures our intention to refactor it.



 Comments   
Comment by Githook User [ 01/May/20 ]

Author:

{'name': 'Gabriel Russell', 'email': 'gabriel.russell@mongodb.com', 'username': 'gabrielrussell'}

Message: SERVER-45269 remove orphaned log_test_v2.h

(cherry picked from commit 79010118a6bdb727560003ff5a0d83ba05d531b4)
Branch: v4.4
https://github.com/mongodb/mongo/commit/f0ee60e3bc9d9d0e311c15b343b837ee6b30369b

Comment by Githook User [ 29/Apr/20 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-45269 refactor log_test_v2

(cherry picked from commit cec8d6e7b6b3191020b8c00e498b64ddc0824586)
Branch: v4.4
https://github.com/mongodb/mongo/commit/9518dbefea033656519801de6775fb53b0f5a4b3

Comment by Githook User [ 20/Apr/20 ]

Author:

{'name': 'Gabriel Russell', 'email': 'gabriel.russell@mongodb.com', 'username': 'gabrielrussell'}

Message: SERVER-45269 remove orphaned log_test_v2.h
Branch: master
https://github.com/mongodb/mongo/commit/79010118a6bdb727560003ff5a0d83ba05d531b4

Comment by Githook User [ 25/Mar/20 ]

Author:

{'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue', 'username': 'BillyDonahue'}

Message: SERVER-45269 refactor log_test_v2
Branch: master
https://github.com/mongodb/mongo/commit/cec8d6e7b6b3191020b8c00e498b64ddc0824586

Comment by Billy Donahue [ 24/Mar/20 ]

CR https://mongodbcr.appspot.com/570690022/

Generated at Thu Feb 08 05:08:21 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.