[SERVER-45292] fix isMetadataDifferent logic in chunk manager targeter Created: 23/Dec/19 Updated: 29/Oct/23 Resolved: 26/Dec/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.3 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Eric Milkie | Assignee: | Esha Maharishi (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||
| Sprint: | Sharding 2019-12-30 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Linked BF Score: | 28 | ||||||||||||||||||||
| Description |
|
When we introduced database versioning, one of the cases in isMetadataDifferent was logically reversed. This resulted in the batch exec retry loop thinking that every retry had changed targeting, which caused certain types of errors to be retried indefinitely instead of stopping at the default limit of "5 retries". |
| Comments |
| Comment by Githook User [ 26/Dec/19 ] |
|
Author: {'name': 'Esha Maharishi', 'email': 'esha.maharishi@mongodb.com', 'username': 'EshaMaharishi'}Message: |
| Comment by Eric Milkie [ 23/Dec/19 ] |
|
My attempt at fixing this failed because fixing the logic in isMetadataDifferent broke some jstests that were expecting unsharded collections (like track_unsharded_collections_rename_collection.js) |