[SERVER-45313] validate commit message doesn't escape commit messages properly Created: 27/Dec/19 Updated: 29/Oct/23 Resolved: 27/Dec/19 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.3 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | David Bradford (Inactive) | Assignee: | David Bradford (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Operating System: | ALL |
| Sprint: | DAG 2019-12-30 |
| Participants: | |
| Story Points: | 1 |
| Description |
|
There was an issue with validate_commit when a commit message had both double quotes (") and parens in it. It caused a bash error when we tried to process it. We should ensure that commit messages are properly escaped when passed to the script. As a Server engineer, AC:
|
| Comments |
| Comment by Githook User [ 27/Dec/19 ] |
|
Author: {'name': 'David Bradford', 'email': 'david.bradford@mongodb.com', 'username': 'dbradf'}Message: |
| Comment by David Bradford (Inactive) [ 27/Dec/19 ] |
|
My guess is that this is due to the commit message being an evergreen expansion as opposed to a shell variable. |