[SERVER-45344] ReplicaSetChangeNotifier functions should be noexcept Created: 03/Jan/20 Updated: 29/Oct/23 Resolved: 13/Jan/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.3 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Benjamin Caimano (Inactive) | Assignee: | Amirsaman Memaripour |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | neweng, save-for-sam | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 60 | ||||||||
| Description |
|
The core handler functions for the RSCN would disrupt the entire scanning thread if an exception were to pop out. They should be noexcept. This also means we should look at ReplicaSetChangeNotifier::Listener subclasses and see if we need to try-catch. I suspect that the Mongos/ConfigServer update subclasses do need a try-catch and the ConnectionPool controller subclass does not. |
| Comments |
| Comment by Githook User [ 13/Jan/20 ] |
|
Author: {'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@10gen.com'}Message: |