[SERVER-45344] ReplicaSetChangeNotifier functions should be noexcept Created: 03/Jan/20  Updated: 29/Oct/23  Resolved: 13/Jan/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.3.3

Type: Task Priority: Major - P3
Reporter: Benjamin Caimano (Inactive) Assignee: Amirsaman Memaripour
Resolution: Fixed Votes: 0
Labels: neweng, save-for-sam
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Backwards Compatibility: Fully Compatible
Participants:
Linked BF Score: 60

 Description   

The core handler functions for the RSCN would disrupt the entire scanning thread if an exception were to pop out. They should be noexcept. This also means we should look at ReplicaSetChangeNotifier::Listener subclasses and see if we need to try-catch. I suspect that the Mongos/ConfigServer update subclasses do need a try-catch and the ConnectionPool controller subclass does not.



 Comments   
Comment by Githook User [ 13/Jan/20 ]

Author:

{'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@10gen.com'}

Message: SERVER-45344 RSCN functions should be noexcept
Branch: master
https://github.com/mongodb/mongo/commit/fc68ed4f8635d7c56f48d313f98f7ee65ea5270c

Generated at Thu Feb 08 05:08:32 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.