[SERVER-45378] IndexBuildsCoordinator::_setUpIndexBuild() can throw exceptions which should be caught and clean (unregister) the index build Created: 06/Jan/20 Updated: 29/Oct/23 Resolved: 05/Feb/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.4 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Suganthi Mani | Assignee: | Benety Goh |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Operating System: | ALL | ||||||||||||||||
| Sprint: | Execution Team 2020-02-10 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Linked BF Score: | 23 | ||||||||||||||||
| Description |
|
The "IndexBuildsCoordinatorMongod" thread can throw DB exception "ErrorCodes::MaxTimeMSExpired" if the opCtx deadline gets expired. Currently, we acquire locks here in IndexBuildsCoordinator::_setUpIndexBuild which are allowed to throw exceptions. But, we don't catch those exceptions for _setUpIndexBuild(). This can result in server to crash. I feel, we should follow exception handling something similar to IndexBuildsCoordinator::_runIndexBuild.. On catching the exception, we should also make sure we cleanup(unregister) the index build. |
| Comments |
| Comment by Githook User [ 05/Feb/20 ] |
|
Author: {'username': 'benety', 'name': 'Benety Goh', 'email': 'benety@mongodb.com'}Message: |
| Comment by Githook User [ 04/Feb/20 ] |
|
Author: {'name': 'Benety Goh', 'username': 'benety', 'email': 'benety@mongodb.com'}Message: |
| Comment by Githook User [ 04/Feb/20 ] |
|
Author: {'username': 'benety', 'name': 'Benety Goh', 'email': 'benety@mongodb.com'}Message: |