[SERVER-45558] Revert logging additions for TLA+ Trace Checker project Created: 14/Jan/20  Updated: 29/Oct/23  Resolved: 29/Jan/20

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.3.4

Type: Task Priority: Major - P3
Reporter: A. Jesse Jiryu Davis Assignee: A. Jesse Jiryu Davis
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Participants:

 Description   

We've decided to stop implementation of the TLA+ Trace Checker and write the paper describing how far we got, so the extra logging code will become dead code soon. Once we've done any final experiments for the paper, revert the logging changes made for SERVER-43589 "Add logging to be used by TLA+ trace checker for RaftMongo.tla".

Update the instructions in https://github.com/mongodb-labs/repl-trace-checker/blob/master/README.md once we have reverted the logging changes.



 Comments   
Comment by Githook User [ 29/Jan/20 ]

Author:

{'username': 'ajdavis', 'name': 'A. Jesse Jiryu Davis', 'email': 'jesse@mongodb.com'}

Message: SERVER-45558 Revert logging additions for TLA+ Trace Checker project

This is a combination of 6 commits.

Revert "SERVER-44458 Add RaftMongo.tla spec"

This reverts commit 88aaa47b815507e3ddd9a3a79f00d0eaca3ae071.

Revert "SERVER-45184 Ban TLA+ tracing with inMemory"

This reverts commit e57438bd024d04f82dcbcbe68fe223b3f3aec838.

Revert "SERVER-43589 Trace logging for RaftMongo.tla"

This reverts commit f515d2ad5494e64c3be80189e7ea6bceaf267421.

Revert "SERVER-44076 create TLA+ Trace Checking logging framework"

This reverts commit 744200de5f5667334457ee35abfa3747e2e26d55.

Revert "SERVER-43589 Failpoint to log TLA+ trace events"

This reverts commit eda99cf7ca668908e5eb0498845b0270265c44e7.

Revert "SERVER-45106 Add TLA+ log component to logv2"

This reverts commit a60ce00707f0ffdb5d2ec5c3a72993cc2b2d2978.

delete mode 100644 jstests/replsets/tla_plus_trace_checking.js
delete mode 100644 src/mongo/db/repl/replication_coordinator_impl_tla_plus_trace.cpp
delete mode 100644 src/mongo/db/repl/tla_plus_trace_repl.idl
delete mode 100644 src/mongo/util/tla_plus_trace.cpp
delete mode 100644 src/mongo/util/tla_plus_trace.h
delete mode 100644 src/mongo/util/tla_plus_trace.idl
Branch: master
https://github.com/mongodb/mongo/commit/bcae9e6777408882b3d391721dea262c1cdcd16e

Comment by A. Jesse Jiryu Davis [ 28/Jan/20 ]

Updated the repl-trace-checker script README:

https://github.com/mongodb-labs/repl-trace-checker/commit/dcc7aa8b670ff2b9d386fdf7fc3d8b68ac57f741

Comment by A. Jesse Jiryu Davis [ 28/Jan/20 ]

Revert the logging changes for:

commit 88aaa47b815507e3ddd9a3a79f00d0eaca3ae071
Author: A. Jesse Jiryu Davis <jesse@mongodb.com>
Date:   Tue Jan 14 15:51:57 2020 +0000
 
    SERVER-44458 Add RaftMongo.tla spec

Completely revert these:

commit a60ce00707f0ffdb5d2ec5c3a72993cc2b2d2978
Author: Henrik Edin <henrik.edin@mongodb.com>
Date:   Wed Dec 18 16:30:56 2019 +0000
 
    SERVER-45106 Add TLA+ log component to logv2
 
    It was recently added to the old logger.
 
commit e57438bd024d04f82dcbcbe68fe223b3f3aec838
Author: A. Jesse Jiryu Davis <jesse@mongodb.com>
Date:   Tue Dec 17 15:05:58 2019 +0000
 
    SERVER-45184 Ban TLA+ tracing with inMemory
 
commit f515d2ad5494e64c3be80189e7ea6bceaf267421
Author: A. Jesse Jiryu Davis <jesse@mongodb.com>
Date:   Tue Dec 10 21:11:37 2019 +0000
 
    SERVER-43589 Trace logging for RaftMongo.tla
 
commit 744200de5f5667334457ee35abfa3747e2e26d55
Author: Judah Schvimer <judah.schvimer@10gen.com>
Date:   Thu Nov 14 14:30:44 2019 +0000
 
    SERVER-44076 create TLA+ Trace Checking logging framework
 
commit eda99cf7ca668908e5eb0498845b0270265c44e7
Author: A. Jesse Jiryu Davis <jesse@mongodb.com>
Date:   Thu Nov 7 20:49:43 2019 +0000
 
    SERVER-43589 Failpoint to log TLA+ trace events

Generated at Thu Feb 08 05:09:07 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.