[SERVER-45618] eslint taking 30+ minutes in Commit Queue Created: 16/Jan/20  Updated: 29/Oct/23  Resolved: 21/Jan/20

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 4.3.3

Type: Bug Priority: Major - P3
Reporter: David Bradford (Inactive) Assignee: Mathew Robinson (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Dev Platform 2020-01-27
Participants:

 Description   

We are seeing a lot of instances in the commit queue of eslint taking 30+ minutes. After some discussion, it seems like changes might not be using the correct git diff and causing the task to lint the entire code base.

Here is a sample task that hit 36 minutes.

From jonathan.brill:

I think it should work if we diff the upstream master with the working tree, something like git diff master@{upstream}, substituting the branch name of the project for master (I think there's a "branch_name" expansion).

This should work whether or not the patch is a commit queue patch.

 



 Comments   
Comment by David Bradford (Inactive) [ 20/Feb/20 ]

gregory.wlodarek The build you linked is seeing a different problem, which is covered under SERVER-45586.

Comment by Gregory Wlodarek [ 20/Feb/20 ]

Does not seem to be fixed: https://evergreen.mongodb.com/task/mongodb_mongo_master_enterprise_rhel_62_64_bit_lint_eslint_patch_32f47846d78a4fdae9564b7ebb442d53e737d845_5e4e85533627e0398b98ac03_20_02_20_13_11_09

Comment by Githook User [ 21/Jan/20 ]

Author:

{'username': 'chasinglogic', 'name': 'Mathew Robinson', 'email': 'mathew.robinson@mongodb.com'}

Message: SERVER-45618 Update patch file generation to handle Evergreen changes
Branch: master
https://github.com/mongodb/mongo/commit/a0ca6b337c6b5ec671e0daa6039f9532796f0026

Comment by Jonathan Brill [ 17/Jan/20 ]

On second thought, diffing with upstream master won't work for a regular patch if the base of the patch is not the tip of the project's branch.

A better alternative for patches would be to diff with the patch's recorded base commit, something like

git diff ${revision}

where ${revision} is an Evergreen expansion.

Generated at Thu Feb 08 05:09:17 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.