[SERVER-45730] update commit queue message validation Created: 23/Jan/20  Updated: 29/Apr/20  Resolved: 29/Apr/20

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: James O'Leary Assignee: James O'Leary
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-45074 Commit queue commit message validatio... Closed
Sprint: DAG 2020-03-09, DAG 2020-03-23, DAG 2020-04-20, DAG 2020-05-04
Participants:
Story Points: 2

 Description   

We should change the commit message validation to:

  • raise an error when a ticket reference is omitted. Currently this is a warning.
  • handle revert messages where the author can be different to the Jira assignee. Currently this only generates a warning but it should be changed to be handled the similar as a backport.


 Comments   
Comment by James O'Leary [ 29/Apr/20 ]

There is no clear way to map between evergreen author and JIRA username.

When this fails it is very disruptive to end users, so we are not going to apply this validation.

Comment by Githook User [ 29/Apr/20 ]

Author:

{'name': 'David Bradford', 'email': 'david.bradford@mongodb.com', 'username': 'dbradf'}

Message: Revert "SERVER-45730 update commit queue message validation"

This reverts commit 54efb1c92a592f62f05c1eb9aeb92527c6008c08.
Branch: master
https://github.com/mongodb/mongo/commit/609270bc421cdc28368344fbb778924a8f5c85fa

Comment by Githook User [ 28/Apr/20 ]

Author:

{'name': 'Jim OLeary', 'email': 'jim.oleary@gmail.com', 'username': 'jimoleary'}

Message: SERVER-45730 update commit queue message validation
Branch: master
https://github.com/mongodb/mongo/commit/54efb1c92a592f62f05c1eb9aeb92527c6008c08

Comment by Brooke Miller [ 23/Mar/20 ]

Waiting until there's more stability given that everyone's working from home. 

Generated at Thu Feb 08 05:09:34 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.