[SERVER-45751] Multiversion tests do not apply mongod options to last-stable nodes Created: 24/Jan/20  Updated: 29/Oct/23  Resolved: 28/Jan/20

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 4.3.4

Type: Bug Priority: Major - P3
Reporter: Tess Avitabile (Inactive) Assignee: Tess Avitabile (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Repl 2020-01-27, Repl 2020-02-10
Participants:
Linked BF Score: 50

 Description   

We intentionally do not apply mongod options to last-stable nodes here. A result is that the "majority read concern off" variant does not pass --enableMajorityReadConcern:false to last-stable nodes in multiversion test. This means we do not have the multiversion coverage we expect. Also, some tests like oplog_rollover.js assume that the primary and secondary have the same setting of enableMajorityReadConcern.



 Comments   
Comment by Githook User [ 28/Jan/20 ]

Author:

{'email': 'tess.avitabile@mongodb.com', 'name': 'Tess Avitabile', 'username': 'tessavitabile'}

Message: SERVER-45751 Multiversion tests should apply enableMajorityReadConcern to last-stable nodes
Branch: master
https://github.com/mongodb/mongo/commit/15ad788ca299752d5b3fd9f0b526a71036a03286

Comment by Robert Guo (Inactive) [ 24/Jan/20 ]

Yes please do.

Comment by Tess Avitabile (Inactive) [ 24/Jan/20 ]

Sounds good. For now, do you think I should just make enableMajorityReadConcern and exception to the rule? It exists on all supported branches. I want to fix the build and also have multiversion test coverage with enableMajorityReadConcern:false.

Comment by Robert Guo (Inactive) [ 24/Jan/20 ]

Thanks for the heads up Tess. I don't think there's an elegant fix for it right now given it's a known limitation. We have a longer term project to make the test driver/shell more feature-complete. I've added this painpoint to that project (which will be shared out more widely soon).

Comment by Tess Avitabile (Inactive) [ 24/Jan/20 ]

robert.guo, I'm not sure of the correct way to fix this. For enableMajorityReadConcern, we definitely want to pass this option to older version nodes. For the other options, I'm not sure.

CC jason.chan

Generated at Thu Feb 08 05:09:37 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.