[SERVER-4577] output of padding factor is not deterministic, uses globals Created: 29/Dec/11 Updated: 23/Feb/17 Resolved: 23/Feb/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | 2.0.2 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Antoine Girbal | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Participants: |
| Description |
|
test padding.js fails for me quite often when using parallel tests. See below for padding numbers during tests. Good run: Bad run: |
| Comments |
| Comment by auto [ 02/Feb/12 ] | ||||||||||||||||||||||||||||||||||||||||||
|
Author: {u'login': u'agirbal', u'name': u'agirbal', u'email': u'antoine@10gen.com'}Message: | ||||||||||||||||||||||||||||||||||||||||||
| Comment by Aaron Staple [ 17/Jan/12 ] | ||||||||||||||||||||||||||||||||||||||||||
|
Haven't investigated any more since last comment, but the more lenient test is now failing some of the time <http://buildbot.mongodb.org/builders/Linux%2064-bit%20v8/builds/2918/steps/test_5/logs/stdio> | ||||||||||||||||||||||||||||||||||||||||||
| Comment by Aaron Staple [ 29/Dec/11 ] | ||||||||||||||||||||||||||||||||||||||||||
|
I took a look through some data for 6 or so old runs of this test, and I think this data supports my theory above. (Unfortunately the test doesn't print both numbers that are actually checked, but I think it prints enough info to get an accurate feel for what's going on.) In the core suite, the results were nearly identical for all runs. In the parallel basic suite there was more variability. For the numbers I could see, the mean difference at the last part of the test was .0523 and the standard deviation was .00468. The parallel basicPlus suite probably has higher variance though I didn't look at the numbers. So I think lowering the threshold for this test is fine. | ||||||||||||||||||||||||||||||||||||||||||
| Comment by auto [ 29/Dec/11 ] | ||||||||||||||||||||||||||||||||||||||||||
|
Author: {u'login': u'agirbal', u'name': u'agirbal', u'email': u'antoine@10gen.com'}Message: | ||||||||||||||||||||||||||||||||||||||||||
| Comment by Antoine Girbal [ 29/Dec/11 ] | ||||||||||||||||||||||||||||||||||||||||||
|
tweaking padding.js to pass more reliably | ||||||||||||||||||||||||||||||||||||||||||
| Comment by Antoine Girbal [ 29/Dec/11 ] | ||||||||||||||||||||||||||||||||||||||||||
|
from Aaron: Not sure about what's happening but here's a guess. It looks like
|