[SERVER-45793] Improve mongo::Mutex contract Created: 27/Jan/20  Updated: 29/Oct/23  Resolved: 03/Feb/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.3.4

Type: Improvement Priority: Major - P3
Reporter: Benjamin Caimano (Inactive) Assignee: Benjamin Caimano (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Problem/Incident
causes SERVER-46217 Unit tests consistently segfault afte... Closed
Backwards Compatibility: Fully Compatible
Sprint: Service Arch 2020-02-10
Participants:
Linked BF Score: 0

 Description   

The mongo::Mutex documentation could use some additional details as well as stronger language around when to make a LockListener.



 Comments   
Comment by Githook User [ 03/Mar/20 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}

Message: SERVER-43945 Expose out of order latch acquisitions in serverStatus

This commit also backports:

SERVER-42897 Validate base-level latches
SERVER-44746 Fix LatchAnalyzerTest
SERVER-44155 Validate a subset of latches of all levels
SERVER-45691 Change Mutex::LockListeners to use a std::vector again
SERVER-45793 Improve mongo::Mutex contract
SERVER-45424 Track local latch::Identities when getTestCommandsEnabled()
SERVER-46041 Add DiagnosticListener/WaitListener LSAN suppressions
SERVER-46461 Make static in getDiagnosticListenerState() immortal to fix destruction order issues during shutdown
SERVER-46197 Make build flag to disable diagnostic latches
SERVER-45276 Release lock before destroying DBClientBases
Branch: v4.2
https://github.com/mongodb/mongo/commit/24b6ee2dd48e3f1cfde1c4d7e2b01bd73921fbad

Comment by Githook User [ 31/Jan/20 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}

Message: SERVER-45793 Improve mongo::Mutex contract

This additional commit fixes an ASAN failure.
Branch: master
https://github.com/mongodb/mongo/commit/f4f87e2b3f04172974b00eb1fb8666c787c05a12

Comment by Githook User [ 31/Jan/20 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}

Message: SERVER-45793 Improve mongo::Mutex contract
Branch: master
https://github.com/mongodb/mongo/commit/f363c7a5f2db7c41a6ce1dbd25d9347964826686

Comment by Githook User [ 30/Jan/20 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}

Message: Revert "SERVER-45793 Improve mongo::Mutex contract"

This reverts commit 695146e648e032e04d97bb0b4de873272c242f04.
Branch: master
https://github.com/mongodb/mongo/commit/28d4d9cb69b68c759a76851675390cec29855a28

Comment by Githook User [ 29/Jan/20 ]

Author:

{'name': 'Ben Caimano', 'email': 'ben.caimano@10gen.com'}

Message: SERVER-45793 Improve mongo::Mutex contract
Branch: master
https://github.com/mongodb/mongo/commit/695146e648e032e04d97bb0b4de873272c242f04

Generated at Thu Feb 08 05:09:43 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.