[SERVER-46049] Increase diagnosability of _applyOperationForTransaction() Created: 07/Feb/20 Updated: 29/Oct/23 Resolved: 11/Feb/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.4 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Jason Chan | Assignee: | Jason Chan |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Operating System: | ALL | ||||
| Sprint: | Repl 2020-02-10, Repl 2020-02-24 | ||||
| Participants: | |||||
| Linked BF Score: | 23 | ||||
| Description |
|
We should make it so that _applyOperationForTransaction() will return a bad status so that we will actually hit the fassert in the next line. What could happen is that an exception is thrown and then hit the invariant of the destructor of MongoDOperationContextSessionWithoutRefresh. This makes diagnosing BFs hard if we were to fail in this area of the code. |
| Comments |
| Comment by Githook User [ 16/Jul/20 ] |
|
Author: {'name': 'Suganthi Mani', 'email': 'suganthi.mani@mongodb.com', 'username': 'smani87'}Message: (cherry picked from commit 525a83552575efba3274bebb2d4f94b8554c5e16)
(cherry picked from commit 6840394ee0a015939ac7b0497d27fbfe8dda71e4) |
| Comment by Githook User [ 16/Jul/20 ] |
|
Author: {'name': 'Suganthi Mani', 'email': 'suganthi.mani@mongodb.com', 'username': 'smani87'}Message: (cherry picked from commit 525a83552575efba3274bebb2d4f94b8554c5e16)
(cherry picked from commit 6840394ee0a015939ac7b0497d27fbfe8dda71e4) |
| Comment by Githook User [ 10/Feb/20 ] |
|
Author: {'username': 'jasonjhchan', 'name': 'Jason Chan', 'email': 'jason.chan@mongodb.com'}Message: |