[SERVER-46073] Ninja file should track sources as inputs Created: 11/Feb/20  Updated: 06/Dec/22  Resolved: 26/Feb/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Ted Tuckman Assignee: [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive)
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File build.ninja    
Assigned Teams:
Server Development Platform
Operating System: ALL
Steps To Reproduce:

On branch A: Build ninja and compile

switch to branch B

delete a file and remove from SConscript

Try to build

Compile fails with file not found.

 

(in my case with the attached build.ninja the file is stage_constraints.cpp)

Sprint: Dev Platform 2020-03-09
Participants:

 Comments   
Comment by Mathew Robinson (Inactive) [ 26/Feb/20 ]

Ninja doesn't handle source files being deleted gracefully. This is a limitation of Ninja and there isn't really anything we can do about this problem.

Comment by Andrew Morrow (Inactive) [ 20/Feb/20 ]

Should we close this then?

Comment by Mathew Robinson (Inactive) [ 19/Feb/20 ]

I'm not able to repro this behavior and I've discovered that we do track sources as inputs already.

I would expect ninja to fail in this case and require a manual regeneration.

Generated at Thu Feb 08 05:10:26 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.