[SERVER-46120] Error if a batch doesn't have metadata in the oplog fetcher Created: 12/Feb/20 Updated: 29/Oct/23 Resolved: 25/Mar/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.0-rc0, 4.7.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Samyukta Lanka | Assignee: | A. Jesse Jiryu Davis |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | former-quick-wins | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Backwards Compatibility: | Minor Change | ||||||||||||||||||||||||||||
| Backport Requested: |
v4.4
|
||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||
| Description |
|
Right now we check if a new batch has metadata, before processing it or using it in multiple places (like here, here, and here). Each batch should always have metadata, so we should error if that's not the case. This should come with the bonus of cleaning up the code a little, since we only need to check for the metadata once. |
| Comments |
| Comment by Githook User [ 30/Mar/20 ] |
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: (cherry picked from commit 93fe9010473c7d8173f8ea323fdff35a21495a8c) |
| Comment by Githook User [ 30/Mar/20 ] |
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: (cherry picked from commit b36c69c5930d25a8f5ae348a2b2fb24f27f925e6) |
| Comment by Githook User [ 25/Mar/20 ] |
|
Author: {'email': 'jesse@mongodb.com', 'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis'}Message: |
| Comment by Githook User [ 25/Mar/20 ] |
|
Author: {'name': 'A. Jesse Jiryu Davis', 'username': 'ajdavis', 'email': 'jesse@mongodb.com'}Message: |