[SERVER-46129] Ninja generation is slower when using hygienic builds Created: 13/Feb/20 Updated: 27/Oct/23 Resolved: 22/Apr/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.0-rc3 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | Andrew Morrow (Inactive) |
| Resolution: | Gone away | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backport Requested: |
v4.4
|
||||||||||||
| Sprint: | Dev Platform 2020-03-09, Dev Platform 2020-04-20, Dev Platform 2020-05-04 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
Enabling hygienic builds currently slows down Ninja generation. We should do some work to improve performance so the impact is lessened or eliminated. |
| Comments |
| Comment by Githook User [ 26/Apr/20 ] | ||||||||||||||||||||||||||||
|
Author: {'name': 'Mathew Robinson', 'email': 'mathew@chasinglogic.io', 'username': 'chasinglogic'}Message: Some dependencies were getting wired when they should not or were (cherry picked from commit 727fe1181cc8ff8d3c6282662229d28651a927d9) | ||||||||||||||||||||||||||||
| Comment by Andrew Morrow (Inactive) [ 24/Apr/20 ] | ||||||||||||||||||||||||||||
|
The last commit of this ticket didn't make it in time for the v4.4 cut, but if we intend to make ninja_next consistent across both branches, we probably want the fixes there too. | ||||||||||||||||||||||||||||
| Comment by Andrew Morrow (Inactive) [ 22/Apr/20 ] | ||||||||||||||||||||||||||||
|
I can't reproduce the claim of this ticket against the current state of the ninja generator on master. I tried both on my macOS machine and my (very old, very slow) linux machine, and I find no material difference when switching on -
| ||||||||||||||||||||||||||||
| Comment by Githook User [ 06/Mar/20 ] | ||||||||||||||||||||||||||||
|
Author: {'name': 'Mathew Robinson', 'username': 'chasinglogic', 'email': 'mathew@chasinglogic.io'}Message: Some dependencies were getting wired when they should not or were | ||||||||||||||||||||||||||||
| Comment by Githook User [ 28/Feb/20 ] | ||||||||||||||||||||||||||||
|
Author: {'username': 'chasinglogic', 'name': 'Mathew Robinson', 'email': 'mathew@chasinglogic.io'}Message: | ||||||||||||||||||||||||||||
| Comment by Githook User [ 27/Feb/20 ] | ||||||||||||||||||||||||||||
|
Author: {'username': 'chasinglogic', 'name': 'Mathew Robinson', 'email': 'mathew@chasinglogic.io'}Message: | ||||||||||||||||||||||||||||
| Comment by Githook User [ 27/Feb/20 ] | ||||||||||||||||||||||||||||
|
Author: {'username': 'chasinglogic', 'name': 'Mathew Robinson', 'email': 'mathew@chasinglogic.io'}Message: | ||||||||||||||||||||||||||||
| Comment by Githook User [ 27/Feb/20 ] | ||||||||||||||||||||||||||||
|
Author: {'username': 'chasinglogic', 'name': 'Mathew Robinson', 'email': 'mathew@chasinglogic.io'}Message: | ||||||||||||||||||||||||||||
| Comment by Githook User [ 22/Feb/20 ] | ||||||||||||||||||||||||||||
|
Author: {'username': 'chasinglogic', 'name': 'Mathew Robinson', 'email': 'mathew@chasinglogic.io'}Message: |