[SERVER-46144] -Wsign-compare warnings in mozjs build Created: 13/Feb/20  Updated: 06/Dec/22  Resolved: 09/Apr/20

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Billy Donahue Assignee: DO NOT USE - Backlog - Dev Tools
Resolution: Duplicate Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
duplicates SERVER-46860 suppress mozjs -Wsign-compare build w... Closed
Assigned Teams:
Developer Tools
Participants:

 Description   

These 4 warnings happen on every clean mongod build.
We should get rid of them by setting appropriate CXXFLAGS when compiling mozjs.

[1260/3530] Compiling build/dynamic_gcc_ninja/third_party/mozjs-60/extract/modules/fdlibm/e_sqrt.dyn.o
src/third_party/mozjs-60/extract/modules/fdlibm/e_sqrt.cpp: In function ‘double fdlibm::sqrt(double)’:
src/third_party/mozjs-60/extract/modules/fdlibm/e_sqrt.cpp:158:16: warning: comparison of integer expressions of different signedness: ‘uint32_t’ {aka ‘unsigned int’} and ‘int32_t’ {aka ‘int’} [-Wsign-compare]
   if(((t1&sign)==sign)&&(s1&sign)==0) s0 += 1;
       ~~~~~~~~~^~~~~~
[1264/3530] Compiling build/dynamic_gcc_ninja/third_party/mozjs-60/extract/modules/fdlibm/e_pow.dyn.o
src/third_party/mozjs-60/extract/modules/fdlibm/e_pow.cpp: In function ‘double fdlibm::pow(double, double)’:
src/third_party/mozjs-60/extract/modules/fdlibm/e_pow.cpp:131:21: warning: comparison of integer expressions of different signedness: ‘int32_t’ {aka ‘int’} and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
       if((j<<(52-k))==ly) yisint = 2-(j&1);
          ~~~~~~~~~~~^~~~
[1267/3530] Compiling build/dynamic_gcc_ninja/third_party/mozjs-60/extract/modules/fdlibm/s_ceil.dyn.o
src/third_party/mozjs-60/extract/modules/fdlibm/s_ceil.cpp: In function ‘double fdlibm::ceil(double)’:
src/third_party/mozjs-60/extract/modules/fdlibm/s_ceil.cpp:63:8: warning: comparison of integer expressions of different signedness: ‘uint32_t’ {aka ‘unsigned int’} and ‘int32_t’ {aka ‘int’} [-Wsign-compare]
    if(j<i1) i0+=1; /* got a carry */
       ~^~~
[1272/3530] Compiling build/dynamic_gcc_ninja/third_party/mozjs-60/extract/modules/fdlibm/s_floor.dyn.o
src/third_party/mozjs-60/extract/modules/fdlibm/s_floor.cpp: In function ‘double fdlibm::floor(double)’:
src/third_party/mozjs-60/extract/modules/fdlibm/s_floor.cpp:64:8: warning: comparison of integer expressions of different signedness: ‘uint32_t’ {aka ‘unsigned int’} and ‘int32_t’ {aka ‘int’} [-Wsign-compare]
    if(j<i1) i0 +=1 ;  /* got a carry */
       ~^~~


Generated at Thu Feb 08 05:10:37 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.