[SERVER-46171] NewOplogFetcher should check for shutdown before retrying the initial connection Created: 14/Feb/20 Updated: 29/Oct/23 Resolved: 14/Feb/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 4.3.4 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Lingzhi Deng | Assignee: | Lingzhi Deng |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Operating System: | ALL |
| Sprint: | Repl 2020-02-24 |
| Participants: |
| Description |
|
In NewOplogFetcher::_connect, if connect/auth fails, it depends on _oplogFetcherRestartDecision->shouldContinue to determine whether it should retry the connection. During initial sync, shouldContinue always return true for network errors. This means, the while loop in _connect() is effectively an infinite loop during initial sync. This is fine but it should honor the shutdown signal. And it would be better to backoff a bit on retries. |
| Comments |
| Comment by Githook User [ 14/Feb/20 ] |
|
Author: {'name': 'Lingzhi Deng', 'username': 'ldennis', 'email': 'lingzhi.deng@mongodb.com'}Message: |