[SERVER-46257] OplogFetcher should run LogicalTimeMetadataHook on reply metadata Created: 19/Feb/20  Updated: 29/Oct/23  Resolved: 22/Feb/20

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 4.3.4

Type: Bug Priority: Major - P3
Reporter: Lingzhi Deng Assignee: Lingzhi Deng
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Related
related to SERVER-35663 Replication recovery does not update ... Closed
related to SERVER-27749 Integrate LogicalTimeMetadata with me... Closed
related to SERVER-45574 Replace OplogFetcher with NewOplogFet... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Repl 2020-02-24
Participants:
Linked BF Score: 21

 Description   

Before SERVER-45574, OplogFetcher used RemoteCommandRetryScheduler on the ReplicationExecutor to run oplog fetching queries. And all connections in the executor thread pool run LogicalTimeMetadataHook on incoming command replies to advance the logical clock.
After SERVER-45574, OplogFetcher uses DBClientConnection and DBClientCursor for oplog fetching. So we should add cluster time metadata handling to the DBClientConnection's metadata reader. Otherwise, the syncing node could advance the commit point (in processMetadata) beyond the logical clock.



 Comments   
Comment by Githook User [ 22/Feb/20 ]

Author:

{'name': 'Lingzhi Deng', 'username': 'ldennis', 'email': 'lingzhi.deng@mongodb.com'}

Message: SERVER-46257: OplogFetcher should run LogicalTimeMetadataHook on DBClientConnection
Branch: master
https://github.com/mongodb/mongo/commit/6377ae0fd9c4632d7cefc44ba80b173e958295d2

Comment by Githook User [ 21/Feb/20 ]

Author:

{'name': 'Lingzhi Deng', 'username': 'ldennis', 'email': 'lingzhi.deng@mongodb.com'}

Message: Revert "SERVER-46257: OplogFetcher should run LogicalTimeMetadataHook on DBClientConnection"

This reverts commit 830fbc2939c577f0904ba1202c1eca9d8e921c54.
Branch: master
https://github.com/mongodb/mongo/commit/564a36122ee2ca3685cd888ce183e112e2ec0a58

Comment by Githook User [ 20/Feb/20 ]

Author:

{'username': 'ldennis', 'name': 'Lingzhi Deng', 'email': 'lingzhi.deng@mongodb.com'}

Message: SERVER-46257: OplogFetcher should run LogicalTimeMetadataHook on DBClientConnection
Branch: master
https://github.com/mongodb/mongo/commit/830fbc2939c577f0904ba1202c1eca9d8e921c54

Generated at Thu Feb 08 05:10:57 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.