[SERVER-46364] Duplicate id checking should occur during lint phase of build, not compile Created: 24/Feb/20 Updated: 29/Oct/23 Resolved: 20/Mar/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.0-rc0, 4.7.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Andy Schwerin | Assignee: | Henrik Edin |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||
| Backport Requested: |
v4.4
|
||||||||||||||||||||
| Sprint: | Dev Tools 2020-03-09, Dev Tools 2020-03-23 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Description |
|
If we move the duplicate log/error id check in scons from the compile phase to the lint phase of patch builds, it will be easier to do printf debugging because you'll be able to run the patch build with duplicate log ids (enabling cut-and-pasting log lines), and only get a lint failure rather than a compile failure. |
| Comments |
| Comment by Githook User [ 26/Mar/20 ] |
|
Author: {'name': 'Henrik Edin', 'username': 'henrikedin', 'email': 'henrik.edin@mongodb.com'}Message: (cherry picked from commit 560f40b2bfcccd731708be9ed49676a2ca72a146) |
| Comment by Githook User [ 20/Mar/20 ] |
|
Author: {'name': 'Henrik Edin', 'username': 'henrikedin', 'email': 'henrik.edin@mongodb.com'}Message: |