[SERVER-46367] Remove ScanningReplicaSetMonitor specific members from the abstract ReplicaSetMonitor class Created: 24/Feb/20 Updated: 29/Oct/23 Resolved: 02/Jul/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.7.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Haley Connelly | Assignee: | Haley Connelly |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | sharding-wfbf-day | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Sharding 2020-05-18, Sharding 2020-06-01, Sharding 2020-06-15, Sharding 2020-06-29 | ||||||||
| Participants: | |||||||||
| Description |
|
GOAL: separate ScanningReplicaSetMonitor specific members out from the abstract ReplicaSetMonitor class. Background: In replica_set_monitor.h, several members are intended for unit-tests only and are only relevant to ScanningReplicaSetMonitor's implementation. Why are they in the abstract class right now? We need to inspect the use of these test-only members in dbclient_rs_test and determine (1) if the test should remain ReplicaSetMonitor version agnostic and (2) if the members can safely be moved from the ReplicaSetMonitor to the concrete ScanningReplicaSetMonitor class. |
| Comments |
| Comment by Githook User [ 02/Jul/20 ] |
|
Author: {'name': 'Haley Connelly', 'email': 'haley.connelly@mongodb.com', 'username': 'haleyConnelly'}Message: |
| Comment by Haley Connelly [ 01/Jul/20 ] |
|
We determined that the test-only members should not be ReplicaSetVersion agnostic and dbclient_rs_test should only be run with the ScanningReplicaSetMonitor. |