[SERVER-46519] Regenerating ninja does not require to rebuild the world Created: 02/Mar/20 Updated: 29/Oct/23 Resolved: 27/Apr/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.0-rc4, 4.7.0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Mathew Robinson (Inactive) | Assignee: | Andrew Morrow (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||
| Backport Requested: |
v4.4
|
||||||||||||||||||||
| Sprint: | Dev Platform 2020-03-09, Dev Platform 2020-04-20, Dev Platform 2020-05-04 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Description |
|
@mathias.stearn pointed out on Slack that forcing the implicit dep on the ninja file is incorrect:
We forced this edge before we started using generator=1 which is why we needed it then but no longer do. Meson does not behave this way either. |
| Comments |
| Comment by Githook User [ 29/Apr/20 ] |
|
Author: {'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}Message: (cherry picked from commit dc116507128f70cc2399bf6656764313aa7d7333) |
| Comment by Githook User [ 27/Apr/20 ] |
|
Author: {'name': 'Andrew Morrow', 'email': 'acm@mongodb.com', 'username': 'acmorrow'}Message: |
| Comment by Mathew Robinson (Inactive) [ 06/Mar/20 ] |
|
This is not quite as easy as just removing this implicit edge. For two reasons:
|