[SERVER-46535] port LogSeverityLimiter to logv2 Created: 02/Mar/20 Updated: 02/Apr/21 Resolved: 02/Apr/21 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Logging |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Gabriel Russell (Inactive) | Assignee: | Sergey Galtsev (Inactive) |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | move-sec | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Sprint: | Security 2021-04-05 | ||||
| Participants: | |||||
| Description |
|
we currently just cast the output, but we should make it support the logv2 types natively. This should include removing the util/log.h include from any files that are currently using LogSeverityLimiter |
| Comments |
| Comment by Sergey Galtsev (Inactive) [ 02/Apr/21 ] |
|
Analysis: Based on code at r4.3.0 tag, LogSeverityLimiter usage was limited to ConnectionPool::SpecificPool::processFailure() and ConnectionPool::SpecificPool::spawnConnections() Both instances of its usage are now replaced with makeSeveritySuppressor() Conclusion: this class does not require porting |
| Comment by Sergey Galtsev (Inactive) [ 02/Apr/21 ] |
|
LogSeverityLimiter last seen on r4.3.0 tag; src/mongo/logger/log_severity_limiter.h . Only usages found are in ConnectionPool via MONGO_GET_LIMITED_SEVERITY |