[SERVER-46666] Add extra validate logging for unit tests for debug proposes Created: 05/Mar/20  Updated: 29/Oct/23  Resolved: 09/Mar/20

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.4.0-rc0, 4.7.0

Type: Question Priority: Major - P3
Reporter: Dianna Hohensee (Inactive) Assignee: Dianna Hohensee (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Problem/Incident
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.4
Sprint: Execution Team 2020-03-09
Participants:
Linked BF Score: 0

 Description   

We have some validate unit tests that are rarely failing to find data corruption. The entries logged after the validate cmd are showing the data corruption that should have been found. The next step is adding logging of the collection and index table entries that validate sees as validate sees the entries. These log messages can be specially toggled on for unit tests only.

Validate is failing to see any data corruption after the first lighter-weight round of validation. There's a second round that collects more information if the first round finds corruption. The test failures show that only the first round runs, so nothing is found in that first round. We need logging for the first round of validation, to narrow down where the error takes place in the code. The first round of validation uses buckets of counters, incrementing for collection table entries and then decrementing for index table entries.



 Comments   
Comment by Githook User [ 13/Mar/20 ]

Author:

{'name': 'Dianna Hohensee', 'username': 'DiannaHohensee', 'email': 'dianna.hohensee@mongodb.com'}

Message: SERVER-46666 Add extra validate logging for unit tests for debug proposes

rename src/mongo/db/storage/

{storage_unittest_debug_util.cpp => storage_debug_util.cpp} (73%)
rename src/mongo/db/storage/{storage_unittest_debug_util.h => storage_debug_util.h} (80%)

(cherry picked from commit 86d40fda4d156c0a439f1c5edb2b7890a085d337)

rename src/mongo/db/storage/{storage_unittest_debug_util.cpp => storage_debug_util.cpp}

(73%)
rename src/mongo/db/storage/

{storage_unittest_debug_util.h => storage_debug_util.h}

(80%)
Branch: v4.4
https://github.com/mongodb/mongo/commit/33076ddc839fda1e5c5dec91d616e56c2e9d40ab

Comment by Githook User [ 09/Mar/20 ]

Author:

{'name': 'Dianna Hohensee', 'username': 'DiannaHohensee', 'email': 'dianna.hohensee@mongodb.com'}

Message: SERVER-46666 Add extra validate logging for unit tests for debug proposes

rename src/mongo/db/storage/

{storage_unittest_debug_util.cpp => storage_debug_util.cpp}

(73%)
rename src/mongo/db/storage/

{storage_unittest_debug_util.h => storage_debug_util.h}

(80%)
Branch: master
https://github.com/mongodb/mongo/commit/86d40fda4d156c0a439f1c5edb2b7890a085d337

Generated at Thu Feb 08 05:12:05 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.