[SERVER-46714] dbtest StorageTimestampTests suite returns successful process exit code despite test failure Created: 09/Mar/20  Updated: 29/Oct/23  Resolved: 27/Apr/20

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 4.4.0-rc7, 4.7.0

Type: Bug Priority: Minor - P4
Reporter: Benety Goh Assignee: Maria van Keulen
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Related
related to SERVER-46722 update StorageTimestampTests Timestam... Closed
is related to SERVER-45010 Clean shutdown after rollbackViaRefet... Closed
is related to SERVER-47219 Correct downgrade_after_rollback_via_... Closed
is related to SERVER-41554 Remove applyOps support for createInd... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.4
Sprint: Execution Team 2020-05-04
Participants:

 Description   

The CI system currently reports the StorageTimestamp dbtest test suite as successful even though the test summary in the logs indicates a failure in the TimestampIndexBuilderOnPrimary test case.

This test case is expected to fail because the underlying applyOps logic was modified in SERVER-41554 to reject createIndexes.

It appears the dbtest executable is exiting early in WiredTigerKVEngine::cleanShutdown() because of the changes in SERVER-45010.



 Comments   
Comment by Githook User [ 19/May/20 ]

Author:

{'name': 'Maria van Keulen', 'email': 'maria@mongodb.com', 'username': 'mvankeulen94'}

Message: SERVER-46714 Only perform EMRC=false shutdown handling when EMRC=false

(cherry picked from commit 147beeb42b443c016615d6b101e0cd54b4d618bc)
Branch: v4.4
https://github.com/mongodb/mongo/commit/9892669cdbd31a44ce565f42c67995056c10c1dd

Comment by Githook User [ 27/Apr/20 ]

Author:

{'name': 'Maria van Keulen', 'email': 'maria@mongodb.com', 'username': 'mvankeulen94'}

Message: SERVER-46714 Only perform EMRC=false shutdown handling when EMRC=false
Branch: master
https://github.com/mongodb/mongo/commit/147beeb42b443c016615d6b101e0cd54b4d618bc

Comment by Maria van Keulen [ 22/Apr/20 ]

Looks like the stableTimestamp check fails because one of the StorageTimestampTests explicitly sets the initialDataTimestamp, but never sets the stableTimestamp. I think the quickest way to address this abnormality is to reset initialDataTimestamp to the null timestamp at the end of the offending test.

Comment by Maria van Keulen [ 22/Apr/20 ]

Judging from the description of SERVER-45010, the quickExit code path is only necessary for eMRC=false. The StorageTimestampTests don't run on eMRC=false, so it seems like only executing the quickExit code path when eMRC=false should address the problem. Adding this restriction would also prevent any other unexpected cases from executing the quickExit.

Update: The fix will still have to make sure StorageTimestampTests doesn't leave the timestamps in an invalid state, particularly if we want to guard against unexpected cases reaching the quickExit code path.

Generated at Thu Feb 08 05:12:14 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.