[SERVER-46716] Support 'let' parameters for updates in sharded environments. Created: 09/Mar/20  Updated: 29/Oct/23  Resolved: 12/Jun/20

Status: Closed
Project: Core Server
Component/s: Aggregation Framework, Write Ops
Affects Version/s: None
Fix Version/s: 4.7.0

Type: New Feature Priority: Major - P3
Reporter: Charlie Swanson Assignee: Pawel Terlecki
Resolution: Fixed Votes: 0
Labels: qopt-team
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-46708 Support 'let' variables in update com... Closed
depends on SERVER-46738 Support 'let' variables for the find ... Closed
is depended on by SERVER-46718 Support 'let' parameters for findAndM... Closed
is depended on by SERVER-46116 Add integration tests for let variabl... Closed
Problem/Incident
Backwards Compatibility: Fully Compatible
Sprint: Query 2020-05-04, Query 2020-05-18, Query 2020-06-01, Query 2020-06-15
Participants:
Linked BF Score: 0

 Description   

When initially investigating, I found that the logic for targeting the updates would fail to parse the request without knowing what the constants were, because it does not provide a real ExpressionContext. In order for this to work, I think we need to make a real ExpressionContext which provides the let variable definitions.



 Comments   
Comment by Githook User [ 12/Jun/20 ]

Author:

{'name': 'Pawel Terlecki', 'email': 'pawel.terlecki@mongodb.com', 'username': 'pterlecki'}

Message: SERVER-46716: Add tests for let parameters for sharded update

Bring back the earlier commit.
Branch: master
https://github.com/mongodb/mongo/commit/4c86696d09d6d53af02452f7a557a9c40eddebfe

Comment by Githook User [ 12/Jun/20 ]

Author:

{'name': 'Katherine Wu', 'email': 'katherine.wu@mongodb.com', 'username': 'kaywux'}

Message: Revert "SERVER-46716: Add tests for let parameters for sharded update"

This reverts commit 41fd8b2a5b227dda18ab81da51e10ecafcf64a52.
Branch: master
https://github.com/mongodb/mongo/commit/914d4a3ab10c0291cc1658d43534d44083cb79d9

Comment by Githook User [ 11/Jun/20 ]

Author:

{'name': 'Pawel Terlecki', 'email': 'pawel.terlecki@mongodb.com', 'username': 'pterlecki'}

Message: SERVER-46716: Add tests for let parameters for sharded update

Made cosmetic changes for the sake of consistency.
Branch: master
https://github.com/mongodb/mongo/commit/41fd8b2a5b227dda18ab81da51e10ecafcf64a52

Generated at Thu Feb 08 05:12:14 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.