[SERVER-46726] Provide separate setParameter to disable diagnostic work Created: 09/Mar/20 Updated: 29/Oct/23 Resolved: 10/Jun/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.1, 4.7.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Benjamin Caimano (Inactive) | Assignee: | Amirsaman Memaripour |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||||||||||||||||||
| Backport Requested: |
v4.4, v4.2
|
||||||||||||||||||||||||||||||||||||||||||||
| Sprint: | Service Arch 2020-03-23, Service Arch 2020-04-06, Service arch 2020-04-20, Service arch 2020-05-04, Service arch 2020-06-01, Service arch 2020-06-15 | ||||||||||||||||||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||||||||||||||||||
| Linked BF Score: | 50 | ||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
We currently use enableTestCommands to enable diagnostic work and loosened permissions. This has an unfortunate side effect where sys-perf notices our non-production diagnostics. The path of least impact is an additional flag that enables "passive" testing behavior in addition to the "active" test commands. Note to server developers: moving forward, the new API for testing diagnostics (i.e., TestingProctor) must be used for any passive testing and diagnostics work (e.g., see latch analyzer for reference). Test commands (i.e., getTestCommandsEnabled) should only be used for registering test commands and anything related to the execution of test commands and fail-points. This enables separately controlling test commands and testing diagnostics. |
| Comments |
| Comment by Githook User [ 19/Aug/20 ] |
|
Author: {'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}Message: (cherry picked from commit 01707971319a5970604c20598f286b2e1882a682) |
| Comment by Githook User [ 19/Aug/20 ] |
|
Author: {'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}Message: (cherry picked from commit ca520c2222a31734bb1ff9523941c86e55f283b5) |
| Comment by Githook User [ 19/Aug/20 ] |
|
Author: {'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}Message: This patch addresses issues concerning running mongos in multiversion tests. (cherry picked from commit 87de9a0cb1e898d7b49c04558e60c40103ee1d8f) |
| Comment by Githook User [ 19/Aug/20 ] |
|
Author: {'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}Message: (cherry picked from commit 674a5f6015ca455f47af4a3b0ebed4b8a9281b8d) |
| Comment by Githook User [ 19/Aug/20 ] |
|
Author: {'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}Message: (cherry picked from commit ac9c07e1014ec0ab28ec90522c8d5043c4bacbc8) |
| Comment by Githook User [ 19/Aug/20 ] |
|
Author: {'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}Message: (cherry picked from commit 1ba3f68f27682084fde335a1cd7f929f1f572a10) |
| Comment by Githook User [ 11/Jun/20 ] |
|
Author: {'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}Message: |
| Comment by Githook User [ 10/Jun/20 ] |
|
Author: {'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}Message: |
| Comment by Githook User [ 10/Jun/20 ] |
|
Author: {'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}Message: This patch addresses issues concerning running mongos in multiversion tests. |
| Comment by Githook User [ 10/Jun/20 ] |
|
Author: {'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}Message: |
| Comment by Githook User [ 10/Jun/20 ] |
|
Author: {'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}Message: |
| Comment by Githook User [ 05/Jun/20 ] |
|
Author: {'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}Message: |