[SERVER-46726] Provide separate setParameter to disable diagnostic work Created: 09/Mar/20  Updated: 29/Oct/23  Resolved: 10/Jun/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.4.1, 4.7.0

Type: Improvement Priority: Major - P3
Reporter: Benjamin Caimano (Inactive) Assignee: Amirsaman Memaripour
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Documented
is documented by DOCS-13701 Investigate changes in SERVER-46726: ... Closed
Gantt Dependency
has to be done before SERVER-48202 Test printStackTrace on initialization Backlog
has to be done before SERVER-48645 Remove versioning constraints on test... Closed
Problem/Incident
causes SERVER-51122 [v4.4] The snapshot window code must ... Closed
Related
related to SERVER-48708 Complete TODO listed in SERVER-46726 Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.4, v4.2
Sprint: Service Arch 2020-03-23, Service Arch 2020-04-06, Service arch 2020-04-20, Service arch 2020-05-04, Service arch 2020-06-01, Service arch 2020-06-15
Participants:
Linked BF Score: 50

 Description   

We currently use enableTestCommands to enable diagnostic work and loosened permissions. This has an unfortunate side effect where sys-perf notices our non-production diagnostics. The path of least impact is an additional flag that enables "passive" testing behavior in addition to the "active" test commands.

Note to server developers: moving forward, the new API for testing diagnostics (i.e., TestingProctor) must be used for any passive testing and diagnostics work (e.g., see latch analyzer for reference). Test commands (i.e., getTestCommandsEnabled) should only be used for registering test commands and anything related to the execution of test commands and fail-points. This enables separately controlling test commands and testing diagnostics.



 Comments   
Comment by Githook User [ 19/Aug/20 ]

Author:

{'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}

Message: SERVER-48708 Remove TODO listed in SERVER-46726

(cherry picked from commit 01707971319a5970604c20598f286b2e1882a682)
Branch: v4.4
https://github.com/mongodb/mongo/commit/3b9eaba9eed1aa99834d5ea21165eed135de48da

Comment by Githook User [ 19/Aug/20 ]

Author:

{'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}

Message: SERVER-46726 Using testing proctor to control diagnostics in "db/repl"

(cherry picked from commit ca520c2222a31734bb1ff9523941c86e55f283b5)
Branch: v4.4
https://github.com/mongodb/mongo/commit/746ec705a41e9e1dcdb0f79df0a95f908671794b

Comment by Githook User [ 19/Aug/20 ]

Author:

{'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}

Message: SERVER-46726 Make multiversion tests work with the new parameter

This patch addresses issues concerning running mongos in multiversion tests.

(cherry picked from commit 87de9a0cb1e898d7b49c04558e60c40103ee1d8f)
Branch: v4.4
https://github.com/mongodb/mongo/commit/7df217f9dbc01d06224f02e4bc12ec813770d3c9

Comment by Githook User [ 19/Aug/20 ]

Author:

{'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}

Message: SERVER-46726 Using testing proctor to control diagnostics

(cherry picked from commit 674a5f6015ca455f47af4a3b0ebed4b8a9281b8d)
Branch: v4.4
https://github.com/mongodb/mongo/commit/a81703ed333939ffa67b3c19786329c8b101dc8b

Comment by Githook User [ 19/Aug/20 ]

Author:

{'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}

Message: SERVER-46726 Using testing proctor to control diagnostics in "db/storage"

(cherry picked from commit ac9c07e1014ec0ab28ec90522c8d5043c4bacbc8)
Branch: v4.4
https://github.com/mongodb/mongo/commit/4a4f6d705d2ba6b71a17e43634b12cb807025e66

Comment by Githook User [ 19/Aug/20 ]

Author:

{'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}

Message: SERVER-46726 Provide separate setParameter to disable diagnostic work

(cherry picked from commit 1ba3f68f27682084fde335a1cd7f929f1f572a10)
Branch: v4.4
https://github.com/mongodb/mongo/commit/3ec2dadba19f0c31924cffed020ed884bbe1d034

Comment by Githook User [ 11/Jun/20 ]

Author:

{'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}

Message: SERVER-48708 Remove TODO listed in SERVER-46726
Branch: master
https://github.com/mongodb/mongo/commit/01707971319a5970604c20598f286b2e1882a682

Comment by Githook User [ 10/Jun/20 ]

Author:

{'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}

Message: SERVER-46726 Using testing proctor to control diagnostics in "db/repl"
Branch: master
https://github.com/mongodb/mongo/commit/ca520c2222a31734bb1ff9523941c86e55f283b5

Comment by Githook User [ 10/Jun/20 ]

Author:

{'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}

Message: SERVER-46726 Make multiversion tests work with the new parameter

This patch addresses issues concerning running mongos in multiversion tests.
Branch: master
https://github.com/mongodb/mongo/commit/87de9a0cb1e898d7b49c04558e60c40103ee1d8f

Comment by Githook User [ 10/Jun/20 ]

Author:

{'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}

Message: SERVER-46726 Using testing proctor to control diagnostics
Branch: master
https://github.com/mongodb/mongo/commit/674a5f6015ca455f47af4a3b0ebed4b8a9281b8d

Comment by Githook User [ 10/Jun/20 ]

Author:

{'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}

Message: SERVER-46726 Using testing proctor to control diagnostics in "db/storage"
Branch: master
https://github.com/mongodb/mongo/commit/ac9c07e1014ec0ab28ec90522c8d5043c4bacbc8

Comment by Githook User [ 05/Jun/20 ]

Author:

{'name': 'Amirsaman Memaripour', 'email': 'amirsaman.memaripour@mongodb.com', 'username': 'samanca'}

Message: SERVER-46726 Provide separate setParameter to disable diagnostic work
Branch: master
https://github.com/mongodb/mongo/commit/1ba3f68f27682084fde335a1cd7f929f1f572a10

Generated at Thu Feb 08 05:12:16 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.