[SERVER-46742] Factor out logic to wait for config commitment into a separate public method Created: 09/Mar/20 Updated: 29/Oct/23 Resolved: 17/Mar/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | William Schultz (Inactive) | Assignee: | William Schultz (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Backport Requested: |
v4.4
|
||||||||||||||||
| Sprint: | Repl 2020-03-23 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
Currently, the logic to wait for a new config to become committed after a safe reconfig lives inside the processReplSetReconfig method of ReplicationCoordinator. We should move this logic into its own, public method on ReplicationCoordinator that external clients can call separately after calling processReplSetReconfig. This will make it easier to write unit tests that don't want to block the calling thread to wait for a config to become committed. Since this waiting logic isn't required for enforcing the safety of safe reconfigs, it is acceptable to move this to a separate public function that can be called, or bypassed, by an external client. For the reconfig command, we will add a call to this new wait method after we process the reconfig command. |
| Comments |
| Comment by Githook User [ 18/Mar/20 ] |
|
Author: {'name': 'William Schultz', 'username': 'will62794', 'email': 'william.schultz@mongodb.com'}Message: (cherry picked from commit 0b0ca37fc915f9f50643b935ff5c5dca2fe96b0f) |
| Comment by Githook User [ 18/Mar/20 ] |
|
Author: {'name': 'William Schultz', 'username': 'will62794', 'email': 'william.schultz@mongodb.com'}Message: (cherry picked from commit c5ba5dcef83fd0cb6ffdcb7d999c46fd38ea5ac1) |
| Comment by Githook User [ 17/Mar/20 ] |
|
Author: {'name': 'William Schultz', 'email': 'william.schultz@mongodb.com', 'username': 'will62794'}Message: |
| Comment by Githook User [ 17/Mar/20 ] |
|
Author: {'name': 'William Schultz', 'email': 'william.schultz@mongodb.com', 'username': 'will62794'}Message: |