[SERVER-46765] mongod --version broken by Structured Logging Created: 10/Mar/20 Updated: 29/Oct/23 Resolved: 28/Mar/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.0-rc0, 4.7.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Billy Donahue | Assignee: | Billy Donahue |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||||||||||||||||||
| Backport Requested: |
v4.4
|
||||||||||||||||||||||||||||||||||||||||||||
| Sprint: | Dev Tools 2020-03-23 | ||||||||||||||||||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||||||||||||||||||
| Linked BF Score: | 0 | ||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
master branch right now: $ mongod --version The problem is that we don't format unused attrs in a log statement anymore. |
| Comments |
| Comment by Githook User [ 18/Sep/20 ] | ||||||||||
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: | ||||||||||
| Comment by Githook User [ 26/Mar/20 ] | ||||||||||
|
Author: {'name': 'Billy Donahue', 'username': 'BillyDonahue', 'email': 'billy.donahue@mongodb.com'}Message: This reverts commit 79a8452b2a813b796059e5eab6c18f685283ce08. with new spot fix: printCommandLineOpts when sending to log (cherry picked from commit 2e58eb2e8a79c4fb4d12465616fa89ab498eb05c) | ||||||||||
| Comment by Githook User [ 26/Mar/20 ] | ||||||||||
|
Author: {'name': 'Billy Donahue', 'username': 'BillyDonahue', 'email': 'billy.donahue@mongodb.com'}Message: (cherry picked from commit 6b1de909f3b9a3bb121f1dddc1cad75ee91a9f1f) | ||||||||||
| Comment by Billy Donahue [ 23/Mar/20 ] | ||||||||||
|
recommitted with a 1-liner fix | ||||||||||
| Comment by Githook User [ 23/Mar/20 ] | ||||||||||
|
Author: {'name': 'Billy Donahue', 'username': 'BillyDonahue', 'email': 'billy.donahue@mongodb.com'}Message: This reverts commit 79a8452b2a813b796059e5eab6c18f685283ce08. with new spot fix: printCommandLineOpts when sending to log | ||||||||||
| Comment by Githook User [ 23/Mar/20 ] | ||||||||||
|
Author: {'name': 'Billy Donahue', 'username': 'BillyDonahue', 'email': 'billy.donahue@mongodb.com'}Message: Revert "Revert " This reverts commit 7ce7c995d20ef7f7881db63f1da2457f8fc62caf. | ||||||||||
| Comment by Githook User [ 23/Mar/20 ] | ||||||||||
|
Author: {'email': 'max.hirschhorn@mongodb.com', 'name': 'Max Hirschhorn', 'username': 'visemet'}Message: Revert " This reverts commit cddfeb0c7cb137d46b14da18a7cfd4905bfab87f. | ||||||||||
| Comment by Githook User [ 23/Mar/20 ] | ||||||||||
|
Author: {'email': 'max.hirschhorn@mongodb.com', 'name': 'Max Hirschhorn', 'username': 'visemet'}Message: Revert " This reverts commit 6b1de909f3b9a3bb121f1dddc1cad75ee91a9f1f. | ||||||||||
| Comment by Githook User [ 20/Mar/20 ] | ||||||||||
|
Author: {'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue', 'username': 'BillyDonahue'}Message: | ||||||||||
| Comment by Githook User [ 20/Mar/20 ] | ||||||||||
|
Author: {'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue', 'username': 'BillyDonahue'}Message: | ||||||||||
| Comment by Githook User [ 16/Mar/20 ] | ||||||||||
|
(Actually should have been attached to Author: {'name': 'Billy Donahue', 'username': 'BillyDonahue', 'email': 'billy.donahue@mongodb.com'}Message: | ||||||||||
| Comment by Billy Donahue [ 13/Mar/20 ] | ||||||||||
|
the buildInfo part of the --version output would have been (had it worked) an array of 1-key objects.
Henrik and I agreed this wasn't quite right. So that will be fixed as part of this ticket. "environment" will be mapped to a single JSON object in the obvious way.
| ||||||||||
| Comment by Billy Donahue [ 12/Mar/20 ] | ||||||||||
|
would also affect the --sysinfo command, which also goes to kPlain format and issues logv2 logs. |