[SERVER-46779] {{replSetResizeOplog}} requires {{size}} when setting {{minRetentionHours}} Created: 10/Mar/20  Updated: 29/Oct/23  Resolved: 27/Mar/20

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: 4.3.4
Fix Version/s: 4.4.0-rc0, 4.7.0

Type: Bug Priority: Major - P3
Reporter: Ravind Kumar (Inactive) Assignee: Gregory Noma
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Documented
is documented by DOCS-13538 Investigate changes in SERVER-46779: ... Closed
Related
related to SERVER-45978 Add a new minRetentionHours argument ... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v4.4
Sprint: Execution Team 2020-04-06
Participants:

 Description   

As of 4.3.4, replSetResizeOplog requires setting the oplog size when configuring minRetentionHours. This is a bit unusual, as it requires the user to retrieve the current oplog size before changing the minimum retention period if they only want to modify the retention period.

This behavior is not reflected in the commandline or configuration file options, where oplogSize or replication.oplogSizeMB are not dependencies.

It looks like design decision happened as part of a discussion during code review:

geert 2020/02/14 18:06:42
We'll always require a size. This is required by capped collections. That
requirement is mostly historical, but not something we should change in this
patch. Not requiring a size would lead to downgrade issues, and would turn into
significant extra work.

As per the review for DOCSP-8653, revisit this discussion and see if this is something that can be fixed while addressing the original downgrade concerns.



 Comments   
Comment by Githook User [ 01/Apr/20 ]

Author:

{'name': 'Gregory Noma', 'email': 'gregory.noma@gmail.com', 'username': 'gregorynoma'}

Message: SERVER-46779 Make replSetResizeOplog not require size parameter

(cherry picked from commit a4a33ae57b2bebaad649d9598880849a6933111e)
Branch: v4.4
https://github.com/mongodb/mongo/commit/80ae3c29b4e293d3929ef05a5e8cbfa69dfae883

Comment by Githook User [ 27/Mar/20 ]

Author:

{'email': 'gregory.noma@gmail.com', 'name': 'Gregory Noma', 'username': 'gregorynoma'}

Message: Revert "SERVER-46779 Make replSetResizeOplog not require size parameter"

This reverts commit 5862665e24170eb9fe9d0977fba1e6dc56a7a257.
Branch: v4.4
https://github.com/mongodb/mongo/commit/e4ad538053ed7914575227de2b6cb596352b239a

Comment by Githook User [ 27/Mar/20 ]

Author:

{'email': 'gregory.noma@gmail.com', 'name': 'Gregory Noma', 'username': 'gregorynoma'}

Message: SERVER-46779 Make replSetResizeOplog not require size parameter

(cherry picked from commit a4a33ae57b2bebaad649d9598880849a6933111e)
Branch: v4.4
https://github.com/mongodb/mongo/commit/725c1e9f6496f05809ee7a0dd1488fa61667e2e5

Comment by Githook User [ 23/Mar/20 ]

Author:

{'email': 'gregory.noma@gmail.com', 'name': 'Gregory Noma', 'username': 'gregorynoma'}

Message: SERVER-46779 Make replSetResizeOplog not require size parameter
Branch: master
https://github.com/mongodb/mongo/commit/a4a33ae57b2bebaad649d9598880849a6933111e

Generated at Thu Feb 08 05:12:24 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.