[SERVER-46795] Allow for possibility of JS interrupt in mr_bigobject_replace.js Created: 11/Mar/20 Updated: 29/Oct/23 Resolved: 11/Mar/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | MapReduce, Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.0-rc0, 4.7.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Charlie Swanson | Assignee: | Charlie Swanson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Backport Requested: |
v4.4
|
||||||||
| Participants: | |||||||||
| Linked BF Score: | 19 | ||||||||
| Description |
|
The test allocates a lot of memory inside the JS execution engine. On some of our testing platforms this can take a long time. I think the best solution is to account for the possibility of the JS being interrupted because this takes too long. I also considered increasing the timeout value during this test. I could also see an argument that the test should be deleted since the assertion here is just testing that we apply the validation on insert - it's not really specific to javascript or mapReduce. I think it's worth having coverage for creating an object in JS larger than the limit nonetheless, and also to ensure we don't ever go through some internal backdoor which circumvents this limit. |
| Comments |
| Comment by Githook User [ 13/Mar/20 ] |
|
Author: {'name': 'Charlie Swanson', 'username': 'cswanson310', 'email': 'charlie.swanson@mongodb.com'}Message: (cherry picked from commit 7bc67e98ce7d93d27d68d0da5220db61a035987e) |
| Comment by Githook User [ 11/Mar/20 ] |
|
Author: {'username': 'cswanson310', 'name': 'Charlie Swanson', 'email': 'charlie.swanson@mongodb.com'}Message: |