[SERVER-46796] Specific errors during prepare should get propagated to the client Created: 11/Mar/20 Updated: 29/Oct/23 Resolved: 28/Apr/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.0-rc4, 4.7.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Maria van Keulen | Assignee: | Gregory Noma |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | ShardedTxn:FutureOptimizations | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||
| Backport Requested: |
v4.4
|
||||||||||||||||||||||||
| Sprint: | Sharding 2020-05-04 | ||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Description |
|
The test must presently check that commitTransaction_forTesting() fails with NoSuchTransaction, but the logs for the test confirm that the OperationNotSupportedInTransaction error does occur:
It seems that the coordinator shard does not propagate the OperationNotSupportedInTransaction error to the caller. It would be nice to propagate errors during prepare to more clearly communicate what caused the prepare to fail. |
| Comments |
| Comment by Githook User [ 30/Apr/20 ] |
|
Author: {'name': 'Gregory Noma', 'email': 'gregory.noma@gmail.com', 'username': 'gregorynoma'}Message: (cherry picked from commit c3652beac9345444f2961724ecb655afa93195ce) |
| Comment by Githook User [ 28/Apr/20 ] |
|
Author: {'name': 'Gregory Noma', 'email': 'gregory.noma@gmail.com', 'username': 'gregorynoma'}Message: |
| Comment by Esha Maharishi (Inactive) [ 31/Mar/20 ] |
|
Bringing this back into Needs Scheduling to take into account the new information Maria noted. |
| Comment by Esha Maharishi (Inactive) [ 11/Mar/20 ] |
|
Here is where the coordinateCommitTransaction command loses information about the specific error code returned from a participant for prepare. |