[SERVER-46798] remove VersionInfoInterface::isSameMajorVersion Created: 11/Mar/20 Updated: 29/Oct/23 Resolved: 16/Mar/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 4.7.0, 4.4.2 |
| Type: | Improvement | Priority: | Trivial - P5 |
| Reporter: | Billy Donahue | Assignee: | Billy Donahue |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Backport Requested: |
v4.4
|
||||||||||||
| Sprint: | Dev Tools 2020-03-23 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
This function has a bad name and only one caller. It's nonorthogonal, doing both a string parse into {major,minor}AND THEN a tuple compare. It doesn't have to be part of the VersionInfoInterface, and we are better off without it. |
| Comments |
| Comment by Billy Donahue [ 16/Mar/20 ] |
|
(The commit message mentions the wrong ticket number. The change fixes THIS ticket,
Author: {'name': 'Billy Donahue', 'username': 'BillyDonahue', 'email': 'billy.donahue@mongodb.com'}Message: |
| Comment by Billy Donahue [ 11/Mar/20 ] |