[SERVER-46799] Update sharding log lines to adhere to LOGV2 style guide Created: 11/Mar/20  Updated: 29/Oct/23  Resolved: 14/Apr/20

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 4.4.0-rc2, 4.7.0

Type: Task Priority: Major - P3
Reporter: Esha Maharishi (Inactive) Assignee: [DO NOT USE] Backlog - Sharding Team
Resolution: Fixed Votes: 0
Labels: sharding-4.4-stabilization
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Related
related to SERVER-47203 LOGV2 macros should protect against f... Closed
Assigned Teams:
Sharding
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.4
Sprint: Sharding 2020-04-06, Sharding 2020-04-20
Participants:

 Description   

Log lines style guide: https://github.com/mongodb/mongo/blob/master/src/mongo/logv2/README.md

Sharding files: https://docs.google.com/spreadsheets/d/1MKMgx9QGSAvgw-Obu3Mud4WFynB5JmXN77aEGKhgOR4/edit#gid=0



 Comments   
Comment by Githook User [ 14/Apr/20 ]

Author:

{'name': 'Esha Maharishi', 'email': 'esha.maharishi@mongodb.com', 'username': 'EshaMaharishi'}

Message: SERVER-46799 Update sharding log lines to adhere to LOGV2 style guide (files missed in the first pass)
Branch: v4.4
https://github.com/mongodb/mongo/commit/be60575cb3feece679da904b77a422ea78986377

Comment by Githook User [ 13/Apr/20 ]

Author:

{'name': 'Esha Maharishi', 'email': 'esha.maharishi@mongodb.com', 'username': 'EshaMaharishi'}

Message: SERVER-46799 Update sharding log lines to adhere to LOGV2 style guide (files missed in the first pass)
Branch: master
https://github.com/mongodb/mongo/commit/17ada65dd6eef3867c2a2890780002729c0abe41

Comment by Githook User [ 07/Apr/20 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-46799 Fix LOGV2 lines in the BatchWriteExecutor

(cherry picked from commit bbc5d49e563669349e1df290afce3f25b424a80a)
Branch: v4.4
https://github.com/mongodb/mongo/commit/f8d1d969e6b3fe28503dc5c250bb6eba38cbd7a3

Comment by Esha Maharishi (Inactive) [ 06/Apr/20 ]

Ah - I was planning to do the rest of the missing ones today, so I'll go ahead and include these ones.

Comment by Kaloian Manassiev [ 06/Apr/20 ]

bruce.lucas brought it up to my attention (through inspecting the log lines from a running server in master) that there are a few more files, which we forgot to update:
https://github.com/mongodb/mongo/blob/master/src/mongo/db/s/migration_coordinator.cpp
https://github.com/mongodb/mongo/blob/master/src/mongo/s/commands/cluster_get_shard_version_cmd.cpp
https://github.com/mongodb/mongo/blob/master/src/mongo/db/s/move_chunk_command.cpp
https://github.com/mongodb/mongo/blob/master/src/mongo/s/sharding_initialization.cpp
https://github.com/mongodb/mongo/blob/master/src/mongo/db/s/periodic_sharded_index_consistency_checker.cpp
https://github.com/mongodb/mongo/blob/master/src/mongo/db/s/config/sharding_catalog_manager_chunk_operations.cpp

Comment by Githook User [ 05/Apr/20 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-46799 Fix LOGV2 lines in the BatchWriteExecutor
Branch: master
https://github.com/mongodb/mongo/commit/bbc5d49e563669349e1df290afce3f25b424a80a

Comment by Max Hirschhorn [ 02/Apr/20 ]

Reopening to track updating the LOGV2 log lines in:

  • src/mongo/db/s/balancer/balancer.cpp
  • src/mongo/db/kill_sessions_common.cpp
  • src/mongo/s/write_ops/batch_write_exec.cpp
  • src/mongo/s/async_requests_sender.cpp

which had gotten missed in the earlier commits.

Comment by Githook User [ 02/Apr/20 ]

Author:

{'name': 'Blake Oler', 'email': 'blake.oler@mongodb.com', 'username': 'BlakeIsBlake'}

Message: SERVER-46799 Update sharding log lines to adhere to LOGV2 style guide

(cherry picked from commit a5a4ec4324381c04597bc8d8fd05aa2f1994786b)
Branch: v4.4
https://github.com/mongodb/mongo/commit/2089106cc92b788ea30f0e60fe3afb00a52aa519

Comment by Githook User [ 01/Apr/20 ]

Author:

{'name': 'Randolph Tan', 'email': 'randolph@10gen.com', 'username': 'renctan'}

Message: SERVER-46799 Update sharding log lines to adhere to LOGV2 style guide

(cherry picked from commit 33f4d4229df474c3537d113048dfad511b34e32d)
Branch: v4.4
https://github.com/mongodb/mongo/commit/c5794ea2233a08cae94665759f1ecbb7af10d099

Comment by Githook User [ 01/Apr/20 ]

Author:

{'name': 'Lamont Nelson', 'email': 'lamont.nelson@Lamonts-MBP.fios-router.home'}

Message: SERVER-46799: update log lines for style guide
Branch: v4.4
https://github.com/mongodb/mongo/commit/96d3b79232ceca57eb8206f5fbbe52a8050c1936

Comment by Githook User [ 31/Mar/20 ]

Author:

{'name': 'Matthew Saltz', 'email': 'matthew.saltz@mongodb.com', 'username': 'saltzm'}

Message: SERVER-46799 Update sharding log lines to adhere to LOGV2 style guide

(cherry picked from commit eed25dd9a2f44dd2db00c01666dcbae3934bb336)
Branch: v4.4
https://github.com/mongodb/mongo/commit/49969943bd13c2235d916639784a3e9cfa3779f4

Comment by Matthew Saltz (Inactive) [ 31/Mar/20 ]

I think it's safe to close this ticket now, I believe my commit was the last one.

Comment by Githook User [ 31/Mar/20 ]

Author:

{'name': 'Matthew Saltz', 'email': 'matthew.saltz@mongodb.com', 'username': 'saltzm'}

Message: SERVER-46799 Update sharding log lines to adhere to LOGV2 style guide
Branch: master
https://github.com/mongodb/mongo/commit/eed25dd9a2f44dd2db00c01666dcbae3934bb336

Comment by Githook User [ 31/Mar/20 ]

Author:

{'name': 'Blake Oler', 'email': 'blake.oler@mongodb.com', 'username': 'BlakeIsBlake'}

Message: SERVER-46799 Update sharding log lines to adhere to LOGV2 style guide
Branch: master
https://github.com/mongodb/mongo/commit/a5a4ec4324381c04597bc8d8fd05aa2f1994786b

Comment by Githook User [ 30/Mar/20 ]

Author:

{'name': 'Tommaso Tocci', 'email': 'tommaso.tocci@mongodb.com', 'username': 'toto-dev'}

Message: SERVER-46799 Update sharding log lines to adhere to LOGV2 style guide

(cherry picked from commit d8f604efe0ef80cfe1a079cd229318ba1997b4f4)
Branch: v4.4
https://github.com/mongodb/mongo/commit/37bb19f6bc1879c5b39c27cd432702209831fe23

Comment by Githook User [ 30/Mar/20 ]

Author:

{'name': 'Esha Maharishi', 'email': 'esha.maharishi@mongodb.com', 'username': 'EshaMaharishi'}

Message: SERVER-46799 Update sharding log lines to adhere to LOGV2 style guide

(cherry picked from commit 63b27df39f84f13728b7ea1637313121a5217152)
Branch: v4.4
https://github.com/mongodb/mongo/commit/896c410abe1098289131d2f372065047bd24b9a8

Comment by Githook User [ 30/Mar/20 ]

Author:

{'name': 'Marcos José Grillo Ramírez', 'email': 'marcos.grillo@mongodb.com', 'username': 'm4nti5'}

Message: SERVER-46799 Update sharding log lines to adhere to LOGV2 style guide

Files checked:

  • cluster_write_cmd.cpp
  • kill_sessions_local.cpp
  • logical_session_cache_impl.cpp
  • session_catalog.cpp
  • session_catalog_mongod.cpp
  • strategy.cpp

(cherry picked from commit 2259073c0d32e54749e5bf595fcd0e6b0b2eb8a4)
Branch: v4.4
https://github.com/mongodb/mongo/commit/8cbc4fcea0b871f7ded89913f482e28be4bbeaba

Comment by Githook User [ 30/Mar/20 ]

Author:

{'name': 'Jack Mulrow', 'email': 'jack.mulrow@mongodb.com', 'username': 'jsmulrow'}

Message: SERVER-46799 Update sharding log lines to adhere to LOGV2 style guide

(cherry picked from commit 2debd8d3f087a50c3c7ec6d3d99ba6b056a24eab)
Branch: v4.4
https://github.com/mongodb/mongo/commit/b3b12e75d5e0e673a6c5139222f67efd0f448a22

Comment by Githook User [ 29/Mar/20 ]

Author:

{'name': 'Cheahuychou Mao', 'username': 'cheahuychou', 'email': 'cheahuychou.mao@mongodb.com'}

Message: SERVER-46799 Update sharding log lines to adhere to LOGV2 style guide

(cherry picked from commit 0c09d563ca9669f0a51f403282274f1a0c4c33cd)
Branch: v4.4
https://github.com/mongodb/mongo/commit/113caf8f61c61a6fae2810f54f5f1cedad2c45a0

Comment by Githook User [ 28/Mar/20 ]

Author:

{'name': 'Max Hirschhorn', 'username': 'visemet', 'email': 'max.hirschhorn@mongodb.com'}

Message: SERVER-46799 Update log messages based on LOGV2 style guide.

(cherry picked from commit a4f4a1c5a114960d762198ff37c24ad114f86885)
Branch: v4.4
https://github.com/mongodb/mongo/commit/f9384328c6d32846510893aa939e0f23ca7159ce

Comment by Githook User [ 25/Mar/20 ]

Author:

{'email': 'esha.maharishi@mongodb.com', 'name': 'Esha Maharishi', 'username': 'EshaMaharishi'}

Message: SERVER-46799 Update sharding log lines to adhere to LOGV2 style guide
Branch: master
https://github.com/mongodb/mongo/commit/63b27df39f84f13728b7ea1637313121a5217152

Comment by Githook User [ 25/Mar/20 ]

Author:

{'name': 'Randolph Tan', 'username': 'renctan', 'email': 'randolph@10gen.com'}

Message: SERVER-46799 Update sharding log lines to adhere to LOGV2 style guide
Branch: master
https://github.com/mongodb/mongo/commit/33f4d4229df474c3537d113048dfad511b34e32d

Comment by Githook User [ 25/Mar/20 ]

Author:

{'email': 'cheahuychou.mao@mongodb.com', 'name': 'Cheahuychou Mao', 'username': 'cheahuychou'}

Message: SERVER-46799 Update sharding log lines to adhere to LOGV2 style guide
Branch: master
https://github.com/mongodb/mongo/commit/0c09d563ca9669f0a51f403282274f1a0c4c33cd

Comment by Githook User [ 24/Mar/20 ]

Author:

{'email': 'tommaso.tocci@mongodb.com', 'name': 'Tommaso Tocci', 'username': 'toto-dev'}

Message: SERVER-46799 Update sharding log lines to adhere to LOGV2 style guide
Branch: master
https://github.com/mongodb/mongo/commit/d8f604efe0ef80cfe1a079cd229318ba1997b4f4

Comment by Githook User [ 23/Mar/20 ]

Author:

{'name': 'Jack Mulrow', 'username': 'jsmulrow', 'email': 'jack.mulrow@mongodb.com'}

Message: SERVER-46799 Update sharding log lines to adhere to LOGV2 style guide
Branch: master
https://github.com/mongodb/mongo/commit/2debd8d3f087a50c3c7ec6d3d99ba6b056a24eab

Comment by Githook User [ 23/Mar/20 ]

Author:

{'name': 'Lamont Nelson', 'email': 'lamont.nelson@Lamonts-MBP.fios-router.home'}

Message: SERVER-46799: update log lines for style guide
Branch: master
https://github.com/mongodb/mongo/commit/6495df6629097d1cd846056f60cc3b5570be8a10

Comment by Githook User [ 23/Mar/20 ]

Author:

{'email': 'max.hirschhorn@mongodb.com', 'name': 'Max Hirschhorn', 'username': 'visemet'}

Message: SERVER-46799 Update log messages based on LOGV2 style guide.
Branch: master
https://github.com/mongodb/mongo/commit/a4f4a1c5a114960d762198ff37c24ad114f86885

Comment by Githook User [ 20/Mar/20 ]

Author:

{'name': 'Marcos José Grillo Ramírez', 'username': 'm4nti5', 'email': 'marcos.grillo@mongodb.com'}

Message: SERVER-46799 Update sharding log lines to adhere to LOGV2 style guide

Files checked:

Comment by Githook User [ 17/Mar/20 ]

Author:

{'email': 'marcos.grillo@mongodb.com', 'name': 'Marcos José Grillo Ramírez', 'username': 'm4nti5'}

Message: Revert "SERVER-46799 Update sharding log lines to adhere to LOGV2 style guide Files checked: * src/mongo/s/commands/cluster_write_cmd.cpp * src/mongo/s/commands/strategy.cpp * src/mongo/db/kill_sessions_local.cpp * src/mongo/db/logical_session_cache_impl.cpp * src/mongo/db/session_catalog.cpp * src/mongo/db/session_catalog_mongod.cpp"

This reverts commit e4c445f8ea52a710fef4375f538083f958879dd7.
Branch: master
https://github.com/mongodb/mongo/commit/47b40d87be09c4fd220d8b8dba769aa39a2ba010

Comment by Githook User [ 17/Mar/20 ]

Author:

{'name': 'Marcos José Grillo Ramírez', 'username': 'm4nti5', 'email': 'marcos.grillo@mongodb.com'}

Message: SERVER-46799 Update sharding log lines to adhere to LOGV2 style guide Files checked: * src/mongo/s/commands/cluster_write_cmd.cpp * src/mongo/s/commands/strategy.cpp * src/mongo/db/kill_sessions_local.cpp * src/mongo/db/logical_session_cache_impl.cpp * src/mongo/db/session_catalog.cpp * src/mongo/db/session_catalog_mongod.cpp
Branch: master
https://github.com/mongodb/mongo/commit/e4c445f8ea52a710fef4375f538083f958879dd7

Generated at Thu Feb 08 05:12:28 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.