[SERVER-46801] readability for unittest framework-generated messages Created: 11/Mar/20  Updated: 29/Oct/23  Resolved: 09/Apr/20

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 4.7.0

Type: Improvement Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File notes.txt    
Issue Links:
Problem/Incident
causes SERVER-47494 Structured logging of unit test resul... Backlog
Backwards Compatibility: Fully Compatible
Sprint: Service Arch 2020-04-06, Service arch 2020-04-20
Participants:
Linked BF Score: 6

 Description   

These are the messages that devs have to read most, and they were fancy tabs-and-newlines pre-structured-logging, so they look really bad and they're critically important to read. So here's a ticket just to prioritize them.



 Comments   
Comment by Githook User [ 30/Apr/20 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-46801 Convert unittest library to structured logs.

Add logv2::LogComponent::kTest

(cherry picked from commit d2789d7e75be524212b8b6ab213577c69632fbfd)
Branch: v4.4
https://github.com/mongodb/mongo/commit/735a609ab7dcce4c942caee522331999aaf1281c

Comment by Githook User [ 30/Apr/20 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-46801 tabular LogComponent defs

(cherry picked from commit d7db0e15e0b97e97404e029abdf2c05d3ec9303d)
Branch: v4.4
https://github.com/mongodb/mongo/commit/9ef1dd12c3a9bef1ec4c872f4c77f7ea7db1b7d4

Comment by Githook User [ 09/Apr/20 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-46801 tabular LogComponent defs
Branch: master
https://github.com/mongodb/mongo/commit/d7db0e15e0b97e97404e029abdf2c05d3ec9303d

Comment by Githook User [ 02/Apr/20 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-46801 Convert unittest library to structured logs.

Add logv2::LogComponent::kTest
Branch: master
https://github.com/mongodb/mongo/commit/d2789d7e75be524212b8b6ab213577c69632fbfd

Comment by Githook User [ 27/Mar/20 ]

Author:

{'email': 'billy.donahue@mongodb.com', 'name': 'Billy Donahue', 'username': 'BillyDonahue'}

Message: SERVER-46801 stacktrace logging cleanup/consolidation
Branch: master
https://github.com/mongodb/mongo/commit/a7b3af69ea629995ff89695622b3121457f969b6

Comment by Billy Donahue [ 27/Mar/20 ]

CR https://mongodbcr.appspot.com/586220012/

Tabular LogComponent definitions, came out of `LogComponent::kTest` work.

Comment by Billy Donahue [ 27/Mar/20 ]

emit structured logs from unittest library itself.
Created a new LogComponent kTest for the messages emitted by the unittest library to set them apart.

CR http://mongodbcr.appspot.com/559180015

Comment by Billy Donahue [ 26/Mar/20 ]

preliminary stacktrace logging improvements
CR https://mongodbcr.appspot.com/553700018/

Comment by Billy Donahue [ 11/Mar/20 ]

I'm looking at the before and after in notes.txt and I don't think it's an improvement at all. It's like we need some post processing stage or something.

Generated at Thu Feb 08 05:12:29 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.