[SERVER-46830] [cluster-wide read/write concern] Remove FCV-dependent code for cluster read/write concern project Created: 12/Mar/20 Updated: 29/Oct/23 Resolved: 08/Apr/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Sharding |
| Affects Version/s: | None |
| Fix Version/s: | 4.7.0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Blake Oler | Assignee: | Kevin Pulo |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||
| Sprint: | Sharding 2020-04-06, Sharding 2020-04-20 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Description |
| Comments |
| Comment by Githook User [ 08/Apr/20 ] |
|
Author: {'name': 'Kevin Pulo', 'email': 'kevin.pulo@mongodb.com', 'username': 'devkev'}Message: |
| Comment by Kevin Pulo [ 07/Apr/20 ] |
|
Apologies for not replying on this sooner. Unfortunately, the changes went in slightly after 4.3.5 was cut. Yes, blacklisting the few remaining affected tests (multiversion_sanity_check_gen suite, and multiVersion/genericSetFCVUsage/initial_sync_last_stable_from_latest.js) seems to be sufficient. The other tests failing on the last attempt have already been disabled or had fix_for_fcv_46 added. I'll shortly send a code review with the necessary changes, and update |
| Comment by Githook User [ 06/Apr/20 ] |
|
Author: {'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}Message: This test exercises interaction between FCV 4.4 and FCV 4.2, therefore it shouldn't be in the 4.5 branch. |
| Comment by Jason Chan [ 02/Apr/20 ] |
|
Actually, I believe we should be using v4.3.5 now since we always download the last released minor version. kevin.pulo Does this version include your fixes? If so, I hope we can get away without having to blacklist any of the multiversion tests. |
| Comment by Jason Chan [ 02/Apr/20 ] |
|
The sharding_multiversion tests should already be disabled on master. Judging from the patch build, it looks like we should also disable the multiversion_sanity_check_gen task. We can do this by commenting it out in the etc/evergreen.yml file similar to how we do it for random_multiversion_replica_sets task shown. |
| Comment by Blake Oler [ 02/Apr/20 ] |
|
Hey kevin.pulo, the sharding_last_stable suite has been disabled for now, and you can tag any failing multiversion and sharding_multiversion tests with the tag "fix_for_fcv_46." Does this unblock you? |