[SERVER-47065] Remove 'use44SortKeys' flag from QueryRequest and AggregationRequest in 4.7 Created: 23/Mar/20  Updated: 29/Oct/23  Resolved: 25/Aug/21

Status: Closed
Project: Core Server
Component/s: Querying
Affects Version/s: None
Fix Version/s: 5.1.0-rc0

Type: Task Priority: Major - P3
Reporter: David Storch Assignee: Adi Agrawal
Resolution: Fixed Votes: 0
Labels: qexec-team
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-56366 Update FCV constants in server code b... Closed
Related
is related to SERVER-43361 Remove compatibility for 4.2 $sortKey... Closed
Backwards Compatibility: Fully Compatible
Sprint: Query Execution 2021-07-12, Query Execution 2021-07-26, QE 2021-08-09, QE 2021-08-23, QE 2021-09-06
Participants:

 Description   

The serialization format for sort keys changed between 4.2 and 4.4. In order to ensure that this did not disrupt the upgrade or downgrade process between 4.2 and 4.4, we introduced a new use44SortKeys flag on the aggregate command, as well as a similar _use44SortKeys flag on the find command.

These flags are no longer necessary in 4.6, since a 4.6 node does not need to remain compatible with 4.2. Most of the relevant code related to the 4.2/4.4 upgrade will be deleted under related ticket SERVER-43361. However, a 4.6 node still needs to be able to accept find and agg commands with the use44SortKeys flag. During upgrade, a 4.4 mongos or mongod might send this flag to a 4.6 mongod. Therefore, a 4.6 will tolerate the presence of the flag, but can completely ignore its value.

In 4.7 development, we can finally remove all remaining traces of use44SortKeys, since a 4.8 node should never receive a command with this flag set.



 Comments   
Comment by Vivian Ge (Inactive) [ 06/Oct/21 ]

Updating the fixversion since branching activities occurred yesterday. This ticket will be in rc0 when it’s been triggered. For more active release information, please keep an eye on #server-release. Thank you!

Comment by Kyle Suarez [ 25/Aug/21 ]

Closing this as it appears to be merged into master. eric.cox, please reopen if I'm missing something here.

Comment by Githook User [ 19/Aug/21 ]

Author:

{'name': 'Adityavardhan Agrawal', 'email': 'adi.agrawal@mongodb.com'}

Message: SERVER-47065 remove use44SortKeys
Branch: master
https://github.com/mongodb/mongo/commit/e9ebf0db9011d7335339ab671c57b318d66eeb49

Comment by Eric Cox (Inactive) [ 28/Jun/21 ]

Marking this as blocked on SERVER-56366 due to the shell not being updated yet to point last-lts to 5.0.

Comment by David Storch [ 23/Mar/20 ]

The proper fixVersion for this ticket is "4.7 Required", but that fixVersion doesn't exist yet. I've temporarily marked it as "4.5 Required" so that we remember to move this into the "4.7 Required" bucket once the latter fixVersion becomes available.

Generated at Thu Feb 08 05:13:11 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.