[SERVER-47070] fix broken DeathTest / util_test Created: 24/Mar/20 Updated: 29/Oct/23 Resolved: 24/Mar/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.0-rc0, 4.7.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Gabriel Russell (Inactive) | Assignee: | Gabriel Russell (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Backport Requested: |
v4.4
|
||||
| Sprint: | Dev Tools 2020-03-23 | ||||
| Participants: | |||||
| Description |
|
DeathTest doesn't catch all exceptions and can let children that were supposed to die think that they're parents who need to run tests, thus causing recursion. Fix DeathTest such that the children can't escape their dying context.
util_test tests that massert dies, but massert doesn't die and instead just throws, resuling in the above error. Just remove the massert tests.
Hopefully this doesn't uncover some other hitherto unseen failure. |
| Comments |
| Comment by Githook User [ 24/Mar/20 ] |
|
Author: {'email': 'gabriel.russell@mongodb.com', 'name': 'Gabriel Russell', 'username': 'gabrielrussell'}Message: o death_test.cpp was allowing throwing "children" to escape their o assert_util_test.cpp was testing that uassert and massert die, o fix RollbackFailsOnUnknownOplogEntryCommandType which was throwing |
| Comment by Githook User [ 24/Mar/20 ] |
|
Author: {'email': 'gabriel.russell@mongodb.com', 'name': 'Gabriel Russell', 'username': 'gabrielrussell'}Message: o death_test.cpp was allowing throwing "children" to escape their o assert_util_test.cpp was testing that uassert and massert die, o fix RollbackFailsOnUnknownOplogEntryCommandType which was throwing |
| Comment by Gabriel Russell (Inactive) [ 24/Mar/20 ] |