[SERVER-47070] fix broken DeathTest / util_test Created: 24/Mar/20  Updated: 29/Oct/23  Resolved: 24/Mar/20

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.4.0-rc0, 4.7.0

Type: Improvement Priority: Major - P3
Reporter: Gabriel Russell (Inactive) Assignee: Gabriel Russell (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Backport Requested:
v4.4
Sprint: Dev Tools 2020-03-23
Participants:

 Description   

DeathTest doesn't catch all exceptions and can let children that were supposed to die think that they're parents who need to run tests, thus causing recursion. Fix DeathTest such that the children can't escape their dying context.

 

util_test tests that massert dies, but massert doesn't die and instead just throws, resuling in the above error. Just remove the massert tests.

 

Hopefully this doesn't uncover some other hitherto unseen failure.



 Comments   
Comment by Githook User [ 24/Mar/20 ]

Author:

{'email': 'gabriel.russell@mongodb.com', 'name': 'Gabriel Russell', 'username': 'gabrielrussell'}

Message: SERVER-47070 fixing recursion in util_test

o death_test.cpp was allowing throwing "children" to escape their
context to become test running "parents" and run more "children"
thus recursion

o assert_util_test.cpp was testing that uassert and massert die,
but uassert and massert don't die

o fix RollbackFailsOnUnknownOplogEntryCommandType which was throwing
instead of dying in a death test
Branch: v4.4
https://github.com/mongodb/mongo/commit/4c059717a5cac4f5296be359e91ec24a10e25874

Comment by Githook User [ 24/Mar/20 ]

Author:

{'email': 'gabriel.russell@mongodb.com', 'name': 'Gabriel Russell', 'username': 'gabrielrussell'}

Message: SERVER-47070 fixing recursion in util_test

o death_test.cpp was allowing throwing "children" to escape their
context to become test running "parents" and run more "children"
thus recursion

o assert_util_test.cpp was testing that uassert and massert die,
but uassert and massert don't die

o fix RollbackFailsOnUnknownOplogEntryCommandType which was throwing
instead of dying in a death test
Branch: master
https://github.com/mongodb/mongo/commit/e693b1f029bc946513c6b6bb7da6cf0406f1b64b

Comment by Gabriel Russell (Inactive) [ 24/Mar/20 ]

https://mongodbcr.appspot.com/570680004/

Generated at Thu Feb 08 05:13:12 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.