[SERVER-47071] CheckReplOplogs can fail to detect a mismatch Created: 24/Mar/20 Updated: 29/Oct/23 Resolved: 10/Apr/20 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication, Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 4.0.19, 4.2.7, 4.4.0-rc3, 4.7.0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Judah Schvimer | Assignee: | Lingzhi Deng |
| Resolution: | Fixed | Votes: | 2 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||
| Backport Requested: |
v4.4, v4.2, v4.0
|
||||||||||||||||||||
| Sprint: | Repl 2020-04-20 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Description |
|
We can see in this comment from max.hirschhorn that CheckReplOplogs did not fail when a node was missing an oplog entry. We should investigate why and fix the hook to catch that case. |
| Comments |
| Comment by Githook User [ 23/Apr/20 ] |
|
Author: {'name': 'Lingzhi Deng', 'email': 'lingzhi.deng@mongodb.com', 'username': 'ldennis'}Message: |
| Comment by Githook User [ 23/Apr/20 ] |
|
Author: {'name': 'Lingzhi Deng', 'email': 'lingzhi.deng@mongodb.com', 'username': 'ldennis'}Message: (cherry picked from commit 1700c42daa8b88c17ca49814b7752b9a1b14d3db) |
| Comment by Githook User [ 23/Apr/20 ] |
|
Author: {'name': 'Lingzhi Deng', 'email': 'lingzhi.deng@mongodb.com', 'username': 'ldennis'}Message: (cherry picked from commit 1700c42daa8b88c17ca49814b7752b9a1b14d3db) |
| Comment by Githook User [ 23/Apr/20 ] |
|
Author: {'name': 'Lingzhi Deng', 'email': 'lingzhi.deng@mongodb.com', 'username': 'ldennis'}Message: (cherry picked from commit 560ee7f0ac9407c37989d2b00cabbc27e183edbc) |
| Comment by Githook User [ 23/Apr/20 ] |
|
Author: {'name': 'Lingzhi Deng', 'email': 'lingzhi.deng@mongodb.com', 'username': 'ldennis'}Message: (cherry picked from commit 1700c42daa8b88c17ca49814b7752b9a1b14d3db) |
| Comment by Githook User [ 09/Apr/20 ] |
|
Author: {'name': 'Lingzhi Deng', 'email': 'lingzhi.deng@mongodb.com', 'username': 'ldennis'}Message: |
| Comment by Lingzhi Deng [ 09/Apr/20 ] |
|
Found another issue where if the hook fails, this in assertOplogEntriesEq would be undefined given how we call the function. I think we should do assertOplogEntriesEq.call instead. This bug doesn't affect the oplog checks but it would fail to dump the oplog when the hook fails. I am reopening this ticket for the fix. |
| Comment by Githook User [ 08/Apr/20 ] |
|
Author: {'name': 'Lingzhi Deng', 'email': 'lingzhi.deng@mongodb.com', 'username': 'ldennis'}Message: |
| Comment by Lingzhi Deng [ 08/Apr/20 ] |
|
This was caused by |